Closed Bug 874583 Opened 7 years ago Closed 7 years ago

Use NS_IMPL_CYCLE_COLLECTION_INHERITED_n in more places

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

No description provided.
I found 33 this can be easily used.
Attached patch use it moreSplinter Review
Comment on attachment 752431 [details] [diff] [review]
use it more

try run was green https://tbpl.mozilla.org/?tree=Try&rev=b9673888ff87
Attachment #752431 - Flags: review?(bugs)
Attachment #752431 - Flags: review?(bugs) → review+
I'd prefer if you left nsHTMLDocument alone for now; I'll be adding a JSObject member to it soonish.
Thanks for the review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6c4dcde4ffe

(In reply to :Ms2ger from comment #4)
> I'd prefer if you left nsHTMLDocument alone for now; I'll be adding a
> JSObject member to it soonish.

Sorry, I landed before I saw this.

I don't think that will actually require reverting this, though.  nsHTMLDocument inherits from nsDocument, which has NS_IMPL_CYCLE_COLLECTION_TRAVERSE_SCRIPT_OBJECTS in it already.
https://hg.mozilla.org/mozilla-central/rev/e6c4dcde4ffe
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.