874619 - Talos jobs do not clean up properly on XP ix machines

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, task)

Description

[Armen [:armenzg]]

It seems that I missed some code changes for the iX Windows machines on talos which I enabled it today.
Win7 and Win8 are now capable of cleaning jobs up.

One of the logs are here:
https://tbpl.mozilla.org/php/getParsedLog.php?id=23214918&tree=Fx-Team&full=1

cd C:\\slave\test\../talos-data
chmod -R a+rwx .
chmod: changing permissions of `.': Permission denied
chmod: changing permissions of `./talos': Permission denied

There are more steps on the log but they fail because of the chmod failing.

Maybe we start buildbot with a different user than on Windows 7.

On XP we have these permissions:
drwxr-xr-x 5 root Administrators       0 May 21 14:58 talos-data

On Win7 we have these permissions:
drwxr-xr-x 5 cltbld Administrators    4096 May 21 14:05 talos-data

Comment 1

[Armen [:armenzg]]

arr, I celebrated a little too early this morning. Sorry about it.

Comment 2

[Q]

Armen, We made some GPO changes to file permissions on the XP machines can you test 001 and see if it behaves correctly?

Comment 3

[Q]

This seems to be due to inheritable permissions acting differently on XP. Much like the sticky bit being set. The users had right to modify but not delete any sub directory being created in  c:\slave\

Comment 4

[Armen [:armenzg]]

It seems to be working.
Q is pushing it for me now.

Comment 5

[Q]

The change is live in the "Files_mozilla_build" GPO and I am forcing a replication to all XP clients.

Comment 6

[Armen [:armenzg]]

Is this done?

Comment 7

[Q]

This was pushed complete on all domain clients by 2013-05-21 15:41:45 PDT