874625 - Use MozbuildObject to get default paths in automation.py

Status: RESOLVED WONTFIX

(Testing :: General, defect)

Description

[(not currently active) Ted Mielczarek]

With the patch in bug 855262, we can get default objdir/srcdir paths without having to preprocess them into automation.py. I think with this + mozinfo we can remove all the preprocessing from automation.py, which is a prerequisite to moving everything off of automation.py.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Use MozbuildObject to get default paths in automation.py

Comment 2

[(not currently active) Ted Mielczarek]

ahal: the method in this patch is what I was suggesting on IRC that you could use.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 752376 [details] [diff] [review]
Use MozbuildObject to get default paths in automation.py

Review of attachment 752376 [details] [diff] [review]:
-----------------------------------------------------------------

In some ways, I wonder why we still need these in here?  In automation, we run with full cli flags to specify these values, can't we just hardcode that cli stuff into the mach/make target so we don't have to worry?

::: build/automation.py.in
@@ +74,5 @@
>  
> +try:
> +    # If we're running from an objdir, we can get defaults for paths.
> +    from mozbuild.base import MozbuildObject
> +    o = MozbuildObject.from_environment()

a variable named o could use a better name, maybe mozbuild or mozBuildObj ?

Comment 4

[(not currently active) Ted Mielczarek]

(In reply to Joel Maher (:jmaher) from comment #3) 
> In some ways, I wonder why we still need these in here?  In automation, we
> run with full cli flags to specify these values, can't we just hardcode that
> cli stuff into the mach/make target so we don't have to worry?


I agree, and I think this is the direction we should go. Getting the defaults from makefile targets is sort of a pain, so I don't think we'll get there until we only support two ways of running the tests: via mach commands and by explicitly specifying all the necessary parameters (like we do on the test slaves).

Comment 5

[(not currently active) Ted Mielczarek]

We're just ditching automation.py instead.