Closed Bug 874682 Opened 7 years ago Closed 7 years ago

[Skia] SkThread_pthreads isn't built

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: gw280, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

We build Skia with the flag telling it we're using SkThread_pthreads, but then we actually build SkThread_none, because we're obviously compulsive liars. Let's fix this.
Duplicate of this bug: 874331
Attached patch fix skthread (obsolete) — Splinter Review
Split out the hunk from the FontHost patch. Before landing I will need to run this thoroughly through try, though, to ensure that it's not causing the intermittent reftest crash we were seeing on the FontHost patch (I don't think it is).
Attachment #752432 - Flags: review?(bjacob)
Comment on attachment 752432 [details] [diff] [review]
fix skthread

Review of attachment 752432 [details] [diff] [review]:
-----------------------------------------------------------------

What about Gonk?
Attachment #752432 - Flags: review?(bjacob) → review+
Does gonk use pthreads?
Yes it does. (It's all like Android, with Linux and Bionic).
So given that, the r+ is actually conditional on adding the gonk case.
Ugh, I pushed the wrong patch to try.
Rebased patch, as apparently we're now using moz.build to specify .cpp files:

https://tbpl.mozilla.org/?tree=Try&rev=958df68299d9
Attached patch fix skthread v2Splinter Review
Attachment #752432 - Attachment is obsolete: true
Attachment #757558 - Flags: review?(bjacob)
Attachment #757558 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/mozilla-central/rev/7d8807db11d2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.