874682 - [Skia] SkThread_pthreads isn't built

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[George Wright (:gw280) (needinfo me!)]

We build Skia with the flag telling it we're using SkThread_pthreads, but then we actually build SkThread_none, because we're obviously compulsive liars. Let's fix this.

Comment 2

[George Wright (:gw280) (needinfo me!)]

Attachment: fix skthread

Split out the hunk from the FontHost patch. Before landing I will need to run this thoroughly through try, though, to ensure that it's not causing the intermittent reftest crash we were seeing on the FontHost patch (I don't think it is).

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 752432 [details] [diff] [review]
fix skthread

Review of attachment 752432 [details] [diff] [review]:
-----------------------------------------------------------------

What about Gonk?

Comment 4

[George Wright (:gw280) (needinfo me!)]

Does gonk use pthreads?

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Yes it does. (It's all like Android, with Linux and Bionic).

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

So given that, the r+ is actually conditional on adding the gonk case.

Comment 7

[George Wright (:gw280) (needinfo me!)]

https://tbpl.mozilla.org/?tree=Try&rev=f49cc1780112

Comment 8

[George Wright (:gw280) (needinfo me!)]

Ugh, I pushed the wrong patch to try.

Comment 9

[George Wright (:gw280) (needinfo me!)]

https://tbpl.mozilla.org/?tree=Try&rev=8e5a467d5295

Comment 10

[George Wright (:gw280) (needinfo me!)]

Rebased patch, as apparently we're now using moz.build to specify .cpp files:

https://tbpl.mozilla.org/?tree=Try&rev=958df68299d9

Comment 11

[George Wright (:gw280) (needinfo me!)]

Attachment: fix skthread v2

Comment 12

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d8807db11d2

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7d8807db11d2