Closed Bug 874726 Opened 7 years ago Closed 7 years ago

Change ShmemYCbCrImage to work on any blob of memory rather than Shmem

Categories

(Core :: Graphics: Layers, defect)

23 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: nical, Assigned: nical)

References

Details

Attachments

(1 file, 2 obsolete files)

The logic inside ShmemYCbCrImage doesn't need to be specific to shmem. in non-cross-process scenario we can use pointers to RAM rather than shmems (see bug 874369) so we want to be able to use ShmemYCbCrImage's logic on any blob of memory.
The class name would become BlobYCbCrSurface.
Attached patch BlobYCbCrSurface (obsolete) — Splinter Review
Assignee: nsilva → nical.bugzilla
Attachment #752504 - Flags: review?(jmuizelaar)
Attached patch BlobYCbCrSurface (obsolete) — Splinter Review
Fix windows build and indentation
Attachment #752504 - Attachment is obsolete: true
Attachment #752504 - Flags: review?(jmuizelaar)
Attachment #752513 - Flags: review?(jmuizelaar)
After a discussion with Jeff we decided it would be nicer to have YCbCrImageDataSerializer and YCbCrImageDataSerializer instead of one class that does both serialization and deserialization of the data.
Attachment #752513 - Attachment is obsolete: true
Attachment #752513 - Flags: review?(jmuizelaar)
Attachment #752638 - Flags: review?(jmuizelaar)
Comment on attachment 752638 [details] [diff] [review]
YCbCrImageDataSerializer/Deserializer

Review of attachment 752638 [details] [diff] [review]:
-----------------------------------------------------------------

Jeff reviewed it on my computer.
Attachment #752638 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/d88ad8015ae4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.