Closed Bug 874731 Opened 11 years ago Closed 11 years ago

[Video] Video app doesn't show recorded video if video db was empty before recording

Categories

(Firefox OS Graveyard :: Gaia::Video, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g18 fixed)

RESOLVED FIXED
Tracking Status
b2g18 --- fixed

People

(Reporter: ben.tian, Assigned: ben.tian)

References

Details

Attachments

(1 file, 1 obsolete file)

bug 868891 fixes gecko device storage to notify gaia video db. But the symptom remains as video app doesn't update dialog.

STR per bug 868891 comment 1:
1) delete all video file. 
2) start Video -> "Load videos on to the memory card" Text view -> Home Key -> Camera -> change recording mode -> Record Complete -> Home Key -> Video  
3) still "Load videos on to the memory card" View
Assignee: nobody → btian
Attachment #752546 - Flags: review?(dflanagan)
(In reply to Ben Tian [:btian] from comment #1)
> Created attachment 752546 [details] [diff] [review]
> link to https://github.com/mozilla-b2g/gaia/pull/9919
Video app updates dialog before metadata parsing and addVideo() finish, so 'no video' overlay remains showing.

David, can you review the patch? It makes video app update dialog after adding the first video and go back to thumbnail list view after deleting the last video.
Re-create PR
--
Video app updates dialog before metadata parsing and addVideo() finish, so 'no video' overlay remains showing.

David, can you review the patch? It makes video app update dialog after adding the first video and go back to thumbnail list view after deleting the last video.
Attachment #752546 - Attachment is obsolete: true
Attachment #752546 - Flags: review?(dflanagan)
Attachment #752641 - Flags: review?(dflanagan)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 752641 [details] [diff] [review]
link to https://github.com/mozilla-b2g/gaia/pull/9926

This is a followup to a tef+ bug. It is kind of a corner-case, though, and only affects the case where the video app is already running when the first video is recorded, so we probably don't need to block on it. But the patch is simple and safe and should be uplifted at least to v1-train.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:
Attachment #752641 - Flags: approval-mozilla-b2g18?
Attachment #752641 - Flags: approval-mozilla-b2g18? → approval-gaia-v1+
Uplifted 2f4d9cf0bcaaa4da5bbb9801a079b3ffaa7e4209 to:
v1-train: 0dfc39540d9b1721c9dcfa081bf52a9e9196a631
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: