874734 - B2G SMS MMS: let SmsService::Send support array of aNumber for sending group sms.

Status: RESOLVED WONTFIX

(Core :: DOM: Device Interfaces, defect)

Description

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Make |SmsService::Send| can support array of aNumber for sending group sms.

Comment 1

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Part 1/2: Interface v1.0

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 752567 [details] [diff] [review]
Part 1/2: Interface v1.0

Review of attachment 752567 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/interfaces/nsISmsService.idl
@@ +27,5 @@
> +  /**
> +   * smsArray is an array of SMS entity. Each SMS entity has number, message and
> +   * nsIMobileMessageCallback.
> +   */
> +  void sendGroupSMS(in jsval smsArray);

I think we can rewrite send() as:

  void send([array, size_is(size)] in DOMString number,
            in DOMString message,
            [array, size_is(size)] in nsIMobileMessageCallback callback,
            in uint32_t size);

See also bug 771458.

::: dom/system/gonk/nsIRadioInterfaceLayer.idl
@@ +124,5 @@
> +  /**
> +   * smsArray is an array of SMS entity. Each SMS entity has number, message and
> +   * nsIMobileMessageCallback.
> +   */
> +  void sendGroupSMS(in jsval smsArray);

ditto.

Comment 3

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 752567 [details] [diff] [review]
Part 1/2: Interface v1.0

Review of attachment 752567 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/interfaces/nsISmsService.idl
@@ +27,5 @@
> +  /**
> +   * smsArray is an array of SMS entity. Each SMS entity has number, message and
> +   * nsIMobileMessageCallback.
> +   */
> +  void sendGroupSMS(in jsval smsArray);

We should rewrite as
  void send(in jsval number,
            in DOMString message,
            [array, size_is(size)] in nsIMobileMessageCallback callback,
            in uint32_t size);

idl generator change "[array, size_is(size)] in DOMString number" to const nsAString & *.
We can't declare a pointer to a reference in C++.

Comment 4

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 752567 [details] [diff] [review]
Part 1/2: Interface v1.0

Review of attachment 752567 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/interfaces/nsISmsService.idl
@@ +27,5 @@
> +  /**
> +   * smsArray is an array of SMS entity. Each SMS entity has number, message and
> +   * nsIMobileMessageCallback.
> +   */
> +  void sendGroupSMS(in jsval smsArray);

Another solution is:
  void send([array, size_is(size)] in wstring number,
            in DOMString message,
            [array, size_is(size)] in nsIMobileMessageCallback callback,
            in uint32_t size);
Use wstring array. IDL generator will change this array to const PRUnichar * *.
After talk with Vicamo, I will take this solution.

Comment 5

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

After more talk with Vicamo, we don't to support other getThreads mechanism in Gecko. So don't need to do this bug.

Comment 6

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

If we need other getThreads mechanism, Gaia developer should support it.