874785 - Web Console: rewrite localization comments and use ordered arguments for multiple parameters

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Francesco Lodolo [:flod]]

As done in bug 872993 for appcacheutils.properties, I tried to improve the entire file:
* Consistent localization comments.
* Use ordered arguments when multiple parameters are called, use %S when there's only one parameter.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Rewrite localization comments and use ordered arguments

I need someone to check if comments for gcliterm.instanceLabel and stacktrace.outputMessage are correct.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 752605 [details] [diff] [review]
Rewrite localization comments and use ordered arguments

Review of attachment 752605 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Francesco Lodolo [:flod] from comment #1)
> Created attachment 752605 [details] [diff] [review]
> Rewrite localization comments and use ordered arguments
> 
> I need someone to check if comments for gcliterm.instanceLabel and
> stacktrace.outputMessage are correct.

They both look fine, great job.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #2)
> They both look fine, great job.

Thanks Michael. 

On a side note, most .properties files in devtools look good, at some point I plan to take a look at gclicommands.properties (almost 1300 lines for less than 300 strings)

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/integration/fx-team/rev/a39263b0c896

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a39263b0c896