Closed
Bug 874787
Opened 11 years ago
Closed 10 years ago
Support legacycaller on proxy bindings
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: Ms2ger, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
4.12 KB,
patch
|
efaust
:
review+
peterv
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
So what's needed here is: 1) Passing ProxyIsCallable as the last argument to NewProxyObject in these cases. 2) Setting up generation of call() and maybe construct() for the proxy handler for the interface; presumably the construct() could actually always throw and live on DOMJSProxyHandler. and then it should all work. Or something.
Assignee | ||
Comment 2•10 years ago
|
||
Doing this now should be simpler, I think; we can just hang it off the JSClass directly. But Chrome's usecounters claim this feature is not used (at least down to 0.01% of sites), so maybe we don't even need it.
Assignee | ||
Comment 3•10 years ago
|
||
Looks like it's actually used on 0.03% of sites according to the Google folks, and bug 969030 comment 4 says we'll need this for web compat.
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8375602 -
Flags: review?(peterv)
Attachment #8375602 -
Flags: review?(efaustbmo)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Whiteboard: [need review]
Updated•10 years ago
|
Attachment #8375602 -
Flags: review?(efaustbmo) → review+
Updated•10 years ago
|
Attachment #8375602 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7aabad87c7d7
Flags: in-testsuite?
Whiteboard: [need review]
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7aabad87c7d7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•