874835 - [camera] the pick activity should allow to accept or reject the photo before sending it to the caller

Status: RESOLVED DUPLICATE of bug 870726

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* open SMS app
* write a new message
* click on the little "attach content" icon in the bottom left
* choose "photo"
* take a picture

Expected:
* as a user I should accept/reject the photo before sending it

Actual:
* the photo is sent to the Sms app as soon as it's taken

leo? because it's related to the MMS work.

Comment 1

[Julien Wajsberg [:julienw]]

Asking UX input stamp from the firefox OS UX team.

Comment 2

[Rob MacDonald [:robmac]]

Hi Julien...

Thanks for catching this one. Although I can't see the "attach content" icon in my release, the expected behaviour you've outlined is in line with our pattern document, located here - https://mozilla.box.com/s/ie6x8zgm8902dveyb5xf 

Page 6, "Picking images from gallery", shows the image preview on screen 4 of the intended flow. Subsequent pages show the flows for video and other content types.

I hope this answers your question. Please flag me if you have any additional questions or concerns. 

- Rob

Comment 3

[Julien Wajsberg [:julienw]]

Rob> the "attach content" icon is only on master :)

thanks for the answer ! should this be in 1.1 or is it due for 1.2 ?

Comment 4

[Rob MacDonald [:robmac]]

(In reply to Julien Wajsberg [:julienw] from comment #3)
> Rob> the "attach content" icon is only on master :)
> 
> thanks for the answer ! should this be in 1.1 or is it due for 1.2 ?

Thanks, Julien... 

The 1.1 / 1.2 question is likely one for the product team. I've flagged Sri as most of the pick activity involves media apps. Sri, please redirect the request if I have the wrong contact. 

- Rob

Comment 5

[Dietrich Ayala (:dietrich)]

Current you *can* reject before sending:

1. long press on image and choose "view", "remove" or "replace".

2. you can not send the message.

I agree that an in-camera UI for "accept", "retake" or "cancel" would be ideal. However, that's not necessary for 1.1. Switching from leo? to koi?.

Comment 6

[Julien Wajsberg [:julienw]]

Dietrich, "caller" meant "the caller app" here ;) it was not targeted to only MMS.

I've seen it's been implemented in Bug 870726 though.