Closed Bug 874842 Opened 7 years ago Closed 5 years ago

nsEventDispatcher::CreateEvent should return nsDOMEvent instead of nsIDOMEvent

Categories

(Core :: DOM: Events, enhancement)

2.0 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: ayg, Assigned: ayg)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Attachment #8645686 - Flags: review?(bugs)
Comment on attachment 8645686 [details] [diff] [review]
Patch

There's an include order problem here, will fix and resubmit.
Attachment #8645686 - Attachment is obsolete: true
Attachment #8645686 - Flags: review?(bugs)
Attached patch PatchSplinter Review
Try is green, except for B2G-specific failures that might be fixed by this patch revision: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d546000d1301
Attachment #8646422 - Flags: review?(khuey)
Comment on attachment 8646422 [details] [diff] [review]
Patch

Review of attachment 8646422 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/events/AnimationEvent.h
@@ +54,5 @@
>  
> +already_AddRefed<mozilla::dom::AnimationEvent>
> +NS_NewDOMAnimationEvent(mozilla::dom::EventTarget* aOwner,
> +                        nsPresContext* aPresContext,
> +                        mozilla::InternalAnimationEvent* aEvent);

nit: \n before #endif, here and everywhere.

::: dom/events/CustomEvent.cpp
@@ +111,5 @@
>    VariantToJsval(aCx, mDetail, aRetval);
>  }
>  
> +already_AddRefed<CustomEvent>
> +NS_NewDOMCustomEvent(mozilla::dom::EventTarget* aOwner,

Just EventTarget?

::: dom/svg/SVGZoomEvent.cpp
@@ +93,5 @@
> +using namespace mozilla;
> +using namespace mozilla::dom;
> +
> +already_AddRefed<SVGZoomEvent>
> +NS_NewDOMSVGZoomEvent(mozilla::dom::EventTarget* aOwner,

just EventTarget?
Attachment #8646422 - Flags: review?(khuey) → review+
Flags: in-testsuite-
(I forgot the r=, oops.  We don't have a pre-commit hook for that?)
https://hg.mozilla.org/mozilla-central/rev/68f0b9143193
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.