Closed
Bug 874842
Opened 11 years ago
Closed 9 years ago
nsEventDispatcher::CreateEvent should return nsDOMEvent instead of nsIDOMEvent
Categories
(Core :: DOM: Events, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file, 1 obsolete file)
119.01 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Bug 867101 comment 4 and 5.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=64e18542a252
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8645686 [details] [diff] [review] Patch There's an include order problem here, will fix and resubmit.
Attachment #8645686 -
Attachment is obsolete: true
Attachment #8645686 -
Flags: review?(bugs)
Assignee | ||
Comment 4•9 years ago
|
||
Try is green, except for B2G-specific failures that might be fixed by this patch revision: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d546000d1301
Attachment #8646422 -
Flags: review?(khuey)
Comment on attachment 8646422 [details] [diff] [review] Patch Review of attachment 8646422 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/events/AnimationEvent.h @@ +54,5 @@ > > +already_AddRefed<mozilla::dom::AnimationEvent> > +NS_NewDOMAnimationEvent(mozilla::dom::EventTarget* aOwner, > + nsPresContext* aPresContext, > + mozilla::InternalAnimationEvent* aEvent); nit: \n before #endif, here and everywhere. ::: dom/events/CustomEvent.cpp @@ +111,5 @@ > VariantToJsval(aCx, mDetail, aRetval); > } > > +already_AddRefed<CustomEvent> > +NS_NewDOMCustomEvent(mozilla::dom::EventTarget* aOwner, Just EventTarget? ::: dom/svg/SVGZoomEvent.cpp @@ +93,5 @@ > +using namespace mozilla; > +using namespace mozilla::dom; > + > +already_AddRefed<SVGZoomEvent> > +NS_NewDOMSVGZoomEvent(mozilla::dom::EventTarget* aOwner, just EventTarget?
Attachment #8646422 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Green build on all platforms: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a19bead9692d
Assignee | ||
Updated•9 years ago
|
Flags: in-testsuite-
Assignee | ||
Comment 8•9 years ago
|
||
(I forgot the r=, oops. We don't have a pre-commit hook for that?)
https://hg.mozilla.org/mozilla-central/rev/68f0b9143193
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•