874842 - nsEventDispatcher::CreateEvent should return nsDOMEvent instead of nsIDOMEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Bug 867101 comment 4 and 5.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=64e18542a252

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Comment on attachment 8645686 [details] [diff] [review]
Patch

There's an include order problem here, will fix and resubmit.

Comment 4

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Try is green, except for B2G-specific failures that might be fixed by this patch revision: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d546000d1301

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8646422 [details] [diff] [review]
Patch

Review of attachment 8646422 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/events/AnimationEvent.h
@@ +54,5 @@
>  
> +already_AddRefed<mozilla::dom::AnimationEvent>
> +NS_NewDOMAnimationEvent(mozilla::dom::EventTarget* aOwner,
> +                        nsPresContext* aPresContext,
> +                        mozilla::InternalAnimationEvent* aEvent);

nit: \n before #endif, here and everywhere.

::: dom/events/CustomEvent.cpp
@@ +111,5 @@
>    VariantToJsval(aCx, mDetail, aRetval);
>  }
>  
> +already_AddRefed<CustomEvent>
> +NS_NewDOMCustomEvent(mozilla::dom::EventTarget* aOwner,

Just EventTarget?

::: dom/svg/SVGZoomEvent.cpp
@@ +93,5 @@
> +using namespace mozilla;
> +using namespace mozilla::dom;
> +
> +already_AddRefed<SVGZoomEvent>
> +NS_NewDOMSVGZoomEvent(mozilla::dom::EventTarget* aOwner,

just EventTarget?

Comment 6

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Green build on all platforms: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a19bead9692d

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/68f0b9143193

Comment 8

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

(I forgot the r=, oops.  We don't have a pre-commit hook for that?)

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/68f0b9143193