Closed Bug 874843 Opened 11 years ago Closed 11 years ago

Intermittent test_plugin_mouse_coords.html | p1 mouse up Y - got 38, expected 28 | p2 mouse up Y - got 38, expected 28 | p3 mouse up Y - got 31, expected 21 followed by failures in test_selection_expanding.html

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
Windows 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26
Tracking Flags:
Tracking Status
firefox24 --- fixed
firefox25 --- fixed
firefox26 --- fixed

People

(Reporter: RyanVM, Assigned: johns)

Details

(Keywords: intermittent-failure)

Attachments

(3 files)

Cleanup plugin_focus_helper test events
7.15 KB, patch
roc
: review+
johns
: checkin+
Details | Diff | Splinter Review
Fix typo in test r=typo
1.49 KB, patch
johns
: review+
johns
: checkin+
Details | Diff | Splinter Review
Fix focus race in test on windows 8
3.21 KB, patch
roc
: review+
johns
: checkin+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=23236791&tree=Fx-Team

WINNT 6.2 fx-team pgo test mochitest-5 on 2013-05-21 21:13:44 PDT for push 1c2ca70f459e
slave: t-w864-ix-074

21:18:54     INFO -  1841 INFO TEST-START | /tests/layout/generic/test/test_plugin_mouse_coords.html
21:18:57     INFO -  1842 INFO Error: Unable to restore focus, expect failures and timeouts.
21:18:58     INFO -  1843 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse down X
21:18:58     INFO -  1844 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse down Y
21:18:58     INFO -  1845 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse move X
21:18:58     INFO -  1846 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse move Y
21:18:58     INFO -  1847 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse up X
21:18:58     INFO -  1848 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse up Y - got 38, expected 28
21:18:58     INFO -  1849 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p2 mouse down X
21:18:58     INFO -  1850 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p2 mouse down Y
21:18:58     INFO -  1851 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p2 mouse move X
21:18:58     INFO -  1852 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p2 mouse move Y
21:18:58     INFO -  1853 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p2 mouse up X
21:18:58     INFO -  1854 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_mouse_coords.html | p2 mouse up Y - got 38, expected 28
21:18:58     INFO -  1855 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p3 mouse down X
21:18:58     INFO -  1856 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p3 mouse down Y
21:18:58     INFO -  1857 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p3 mouse move X
21:18:58     INFO -  1858 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p3 mouse move Y
21:18:58     INFO -  1859 INFO TEST-PASS | /tests/layout/generic/test/test_plugin_mouse_coords.html | p3 mouse up X
21:18:58     INFO -  1860 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_mouse_coords.html | p3 mouse up Y - got 31, expected 21
21:18:58     INFO -  1861 INFO TEST-END | /tests/layout/generic/test/test_plugin_mouse_coords.html | finished in 4082ms

21:19:11     INFO -  1913 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div1 aren't selected (div1-div2, all boxes are overflow: visible;): Selected String: ""
21:19:11     INFO -  1914 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div2 aren't selected (div1-div2, all boxes are overflow: visible;): Selected String: ""
21:19:11     INFO -  1925 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div1 aren't selected (div1-div3, all boxes are overflow: visible;): Selected String: ""
21:19:11     INFO -  1926 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div2 aren't selected (div1-div3, all boxes are overflow: visible;): Selected String: ""
21:19:11     INFO -  1927 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div3 aren't selected (div1-div3, all boxes are overflow: visible;): Selected String: ""
21:19:11     INFO -  1937 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div1 aren't selected (div1-fixedDiv1, all boxes are overflow: visible;): Selected String: ""
21:19:11     INFO -  1938 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div2 aren't selected (div1-fixedDiv1, all boxes are overflow: visible;): Selected String: ""
21:19:11     INFO -  1939 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div3 aren't selected (div1-fixedDiv1, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1941 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of fixedDiv1 aren't selected (div1-fixedDiv1, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1949 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div1 aren't selected (div1-xbl_child, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1950 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div2 aren't selected (div1-xbl_child, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1951 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div3 aren't selected (div1-xbl_child, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1952 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of xbl_child aren't selected (div1-xbl_child, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1953 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of fixedDiv1 aren't selected (div1-xbl_child, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1961 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div1 aren't selected (div1-fixedDiv2, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1962 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div2 aren't selected (div1-fixedDiv2, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1963 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of div3 aren't selected (div1-fixedDiv2, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1964 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of xbl_child aren't selected (div1-fixedDiv2, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1965 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of fixedDiv1 aren't selected (div1-fixedDiv2, all boxes are overflow: visible;): Selected String: ""
21:19:12     INFO -  1966 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_selection_expanding.html | The contents of fixedDiv2 aren't selected (div1-fixedDiv2, all boxes are overflow: visible;): Selected String: ""
Roc, can you please take a look at this frequent orange or suggest someone who can? :)
Flags: needinfo?(roc)
John, are you still working on plugin bugs?
Assignee: nobody → jschoenick
Flags: needinfo?(roc)
There's a bunch of iffy event ordering around here, and these failures all seem to start with an "Unable to restore focus" complaint. I suspect this is because we are calling SimpleTest.finish() before window.close() in these tests, but I added a bunch of strict event ordering and removed some setTimeout(1000)s that were previously just hoping for the best.
Attachment #778737 - Flags: review?(roc)
Keywords: checkin-needed
Whiteboard: [leave open]
Looks like that did the trick
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
(In reply to TinderboxPushlog Robot from comment #127)

Rats.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
BUT WAIT, there was a typo that was making SimpleTest.finish race with window.close!

IT COULD STILL HOLD
https://hg.mozilla.org/mozilla-central/rev/c8bc029b8553

Excelsior!
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
(In reply to TinderboxPushlog Robot from comment #134)
:(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I win!

https://tbpl.mozilla.org/?tree=Try&rev=4430c06ec9a5

Best theory: The test opens a popup window that has OOP child windows (plugins) that have been issued native click events. When we close that window and then call finish(), the harness sees windows hasn't returned focus to the main window yet and attempts to reclaim it. This appears to race with some OS logic and causes firefox to lose focus entirely. The waitForFocus() on the main window after closing the popup just waits for the OS to get around to returning focus to us, and seems to fix everything.

I'm not sure if the other changes are necessary, but they don't hurt.
Attachment #785106 - Flags: review?(roc)
Comment on attachment 785106 [details] [diff] [review]
Fix focus race in test on windows 8

Review of attachment 785106 [details] [diff] [review]:
-----------------------------------------------------------------

genius
Attachment #785106 - Flags: review?(roc) → review+
Attachment #778737 - Flags: checkin+
Whiteboard: [leave open]
Only occurrences since fix #2 are on branches without the patch, hopefully fixed for good this time.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Can we please uplift the other patches to Aurora?
Comment on attachment 785106 [details] [diff] [review]
Fix focus race in test on windows 8

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: Test-only, causes sad sheriffs
Testing completed (on m-c, etc.): On m-c for a week with no further test failures
Risk to taking this patch (and alternatives if risky): None, testsuite only
String or IDL/UUID changes made by this patch: None
Attachment #785106 - Flags: approval-mozilla-aurora?
status-firefox24: --- → affected
status-firefox25: --- → affected
status-firefox26: --- → fixed
Target Milestone: mozilla25 → mozilla26
Comment on attachment 785106 [details] [diff] [review]
Fix focus race in test on windows 8

[Approval Request Comment]
same as aurora
Attachment #785106 - Flags: approval-mozilla-beta?
Comment on attachment 785106 [details] [diff] [review]
Fix focus race in test on windows 8

Actually, this is test-only. Doesn't need release driver approval for uplift.
Attachment #785106 - Flags: approval-mozilla-beta?
Attachment #785106 - Flags: approval-mozilla-aurora?
comment 178 looks like a new/different failure. test_plugin_focus is timing out, breaking the test after it.
(comment 177 occurred on mozilla-release without the fix)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: