New TB Toolbar icon polish

RESOLVED FIXED in Thunderbird 24.0

Status

Thunderbird
Theme
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: JosiahOne, Assigned: JosiahOne)

Tracking

({regression})

23 Branch
Thunderbird 24.0
All
Mac OS X
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Some of the new icons appear to have some imperfections. For example, the contacts button. It has a few extra pixels that were not fully erased, and the active state creates a slight smudge on the left side.

This bug is for fixing all those little details.
Component: Mail Window Front End → Theme
Created attachment 752850 [details] [diff] [review]
Patch.

Patch polishes up the toolbar icons.

Giving myself review+ since it's just an image change. Richard has ui-review.
Attachment #752850 - Flags: ui-review?(richard.marti)
Attachment #752850 - Flags: review-
Comment on attachment 752850 [details] [diff] [review]
Patch.

Yes where were some pixels left in the old images.

ui-r+

I plussed also the r because you minussed it :)
Attachment #752850 - Flags: ui-review?(richard.marti)
Attachment #752850 - Flags: ui-review+
Attachment #752850 - Flags: review-
Attachment #752850 - Flags: review+
Created attachment 752895 [details] [diff] [review]
Patch with PNG optimized images

I run your images through a PNG optimizer. This saves some bytes. The patch is now about 93k and your original is about 140k. After you have checked this images you can also use this patch for check-in if you like.
Comment on attachment 752895 [details] [diff] [review]
Patch with PNG optimized images

Looks good to me. Let's land this one.
Attachment #752895 - Flags: ui-review+
Attachment #752895 - Flags: review+
Attachment #752850 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/27a08233b9ac
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.