Closed
Bug 874896
Opened 12 years ago
Closed 12 years ago
New TB Toolbar icon polish
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 24.0
People
(Reporter: jsbruner, Assigned: jsbruner)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
92.66 KB,
patch
|
jsbruner
:
review+
jsbruner
:
ui-review+
|
Details | Diff | Splinter Review |
Some of the new icons appear to have some imperfections. For example, the contacts button. It has a few extra pixels that were not fully erased, and the active state creates a slight smudge on the left side.
This bug is for fixing all those little details.
|
Assignee | |
Updated•12 years ago
|
Component: Mail Window Front End → Theme
|
|
Assignee | |
Comment 1•12 years ago
|
||
Patch polishes up the toolbar icons.
Giving myself review+ since it's just an image change. Richard has ui-review.
Attachment #752850 -
Flags: ui-review?(richard.marti)
Attachment #752850 -
Flags: review-
|
||
Comment 2•12 years ago
|
||
Comment on attachment 752850 [details] [diff] [review]
Patch.
Yes where were some pixels left in the old images.
ui-r+
I plussed also the r because you minussed it :)
Attachment #752850 -
Flags: ui-review?(richard.marti)
Attachment #752850 -
Flags: ui-review+
Attachment #752850 -
Flags: review-
Attachment #752850 -
Flags: review+
|
|
||
Comment 3•12 years ago
|
||
I run your images through a PNG optimizer. This saves some bytes. The patch is now about 93k and your original is about 140k. After you have checked this images you can also use this patch for check-in if you like.
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 752895 [details] [diff] [review]
Patch with PNG optimized images
Looks good to me. Let's land this one.
Attachment #752895 -
Flags: ui-review+
Attachment #752895 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Attachment #752850 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in
before you can comment on or make changes to this bug.
Description
•