874973 - [MMS] Keyboard not triggered

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Mike Pennisi [:jugglinmike]]

When the Messaging application is first installed, if you navigate directly to an ongoing message thread and select the text entry field (all without selecting any other elements), the keyboard is not displayed.

Steps to reproduce:

- Open the Messaging application
- Re-install the application with `make install-gaia APP=sms`
- Open the Messaging application
- Select a message thread
- Select the text entry field

After the text entry field loses focus, subsequent attempts to enter text trigger the keyboard as expected. Neither forcing the application to close nor re-starting the device is sufficient to make the bug reproducible.

Notably, this bug is only reproducible directly after the Messaging application has been installed, and only when it is installed while the application is already running.

Because reproducing relies on such precise conditions, this bug should be considered low-priority.

Comment 1

[Julien Wajsberg [:julienw]]

Probably a keyboard bug.

Vivien, do you have a clue ?

IMHO the important information here is that the bug is triggered when we reinstall the app while it's running.

Comment 2

[Julien Wajsberg [:julienw]]

tracking? because it probably happens on v1.1.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Does it answer the needinfo? ;) Thanks for having opened the bug and thanks Julien for the time spent to show it to me IRL.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 753217 [details] [diff] [review]
Patch

Review of attachment 753217 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/components/Keyboard.jsm
@@ +49,4 @@
>  
> +    if (topic == 'oop-frameloader-crashed') {
> +      if (this.messageManager == mm) {
> +        // The application has been close unexpectingly. Let's tell the

nit: s/close/closed/

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/projects/birch/rev/8e461d0d00c4

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8e461d0d00c4

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 753217 [details] [diff] [review]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: The keyboard sometimes doesn't show whereas it should. This happens in rare occasions (when the app is killed, eg OOM killer or an update) but this is frustrating enough to warrant an uplift.
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low, we add a new observer and we add the code for thie observer; the existing code is not changed.
String or UUID changes made by this patch: none

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 753217 [details] [diff] [review]
Patch

Many aspects of LMK came later in v1.0.1 development, so we can consider this cleanup.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/b1b0ef32ea78

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/b1b0ef32ea78