874982 - Please start offering the stub installer for Win32 on Release, with the ability to fallback to English-only stub installers

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect, P3)

Description

[Alex Keybl [:akeybl]]

We'll want to do the same for release. Once we have an ETA, please do let us know.

+++ This bug was initially created as a clone of Bug #857199 +++

Please start offering the stub installer for English/Win32 on Beta, permanently.

This change should only impact  https://www.mozilla.org/en-US/firefox/channel/#firefox and https://www.mozilla.org/en-US/firefox/new/, but explicitly should not impact https://www.mozilla.org/en-US/firefox/all/.

Comment 1

[Alex Keybl [:akeybl]]

catlee, can you provide the equivalent of https://bugzilla.mozilla.org/show_bug.cgi?id=857199#c8 for release?

Comment 2

[Chris AtLee [:catlee]]

These already exist as:

http://download.mozilla.org/?product=firefox-21.0&os=win&lang=en-US
http://download.mozilla.org/?product=firefox-latest&os=win&lang=en-US
http://download.mozilla.org/?product=firefox-release-stub&os=win&lang=en-US

Comment 3

[Jennifer Bertsch [:jbertsch]]

Hi-

I'll add this to the mozilla.org Kanban board.

Pmac - Let's talk with Mike about timing.  What is the level of effort to get this done?  Any Fx OS work will take priority over this, but clearly this is also important.  Can anyone else on the team help out with this?

Thx,
Jen

Comment 4

[Paul [:pmac] McLanahan]

Shouldn't be too bad. We've done things like this already. It's only complicated by the fact that I'm at a conference all next week. I should be able to find time to knock it out though if it's the next thing to work on.

Comment 5

[Paul [:pmac] McLanahan]

I'm just getting a chance go implement this. Sorry for the delay.

I noticed something though. The beta product IDs are "firefox-beta-latest" and "firefox-beta-stub". So all the button logic is based around this naming pattern. So when I turn it on for release buttons it gives "firefox-latest" and "firefox-stub". So I need "firefox-release-stub" to be renamed to just "firefox-stub" to keep the naming convention going and avoid more special case code in the buttons. Once that's done we should be able to push this out.

One other point of clarification; I think this is just because it's a clone of the beta bug, but we don't want the button to point to stub just on the pages mentioned in comment #0 right? I think we want it to point to stub on all pages with the only exception being /firefox/all/. Right?

Comment 6

[Chris AtLee [:catlee]]

http://download.mozilla.org/?product=firefox-stub&os=win&lang=en-US should be working now.

Comment 7

[Paul Silaghi, QA [:pauly]]

(In reply to Chris AtLee [:catlee] from comment #6)
> http://download.mozilla.org/?product=firefox-stub&os=win&lang=en-US should
> be working now.
Confirmed. What about comment 0 ?

Comment 8

[Paul [:pmac] McLanahan]

A further question:

Since stub is no default for en-US windows, is the next step more locales and platforms? If so, what will that look like?

I'm trying to devise the system by which we'll enable these future installers, but it'll be different depending if we're going to keep it on windows but offer on more locales, or we'll go to Mac but keep en-US only. We could even some day be offering different sets of locales for each platform (I hope not). I guess I'm asking how flexible do I need to be here?

Comment 9

[Paul [:pmac] McLanahan]

After more thought that was a silly question. Of course we'll need to be as flexible as possible.

But the 2nd part of my question from comment #5 still stands. This should be for all buttons save the firefox/all/ page right?

Comment 10

[Paul [:pmac] McLanahan]

Attachment: Pointer to Github pull request: https://github.com/mozilla/bedrock/pull/952

Pointer to Github pull-request

Comment 11

[Paul [:pmac] McLanahan]

I've attached a link to the pull-request for what I believe is how we want this to work. I can update further if we decide we don't wan all of the buttons on the site to be stub save the /all/ and the installer-help pages.

Comment 12

[Paul [:pmac] McLanahan]

Any updates or new info on this one?

Comment 13

[Alex Keybl [:akeybl]]

(In reply to Paul McLanahan [:pmac] from comment #8)
> A further question:
> 
> Since stub is no default for en-US windows, is the next step more locales
> and platforms? If so, what will that look like?

We're still deciding this, but here are the options:

1. We  plan to enable all non-English stubs at once (and disable non-English if we run into problems)
2. We enable a subset of non-English stubs before enabling all non-English stubs

Note that neither of these options touches upon the full installer /all page. Our preference was #1, but we were waiting to find out if it was feasible from the Metrics perspective. Let's see where aphadke is on this.

Comment 14

[Alex Keybl [:akeybl]]

Anurag let me know we're ready to go with #1.

So basically, we'd like to enable the stub installer for all locales (except on /all), with the ability to only leave the English stub up if necesssary. Does that make sense?

Comment 15

[Mike Alexis [:malexis]]

Anurag, friendly ping since we need your input on Alex's proposed solutions.

Comment 16

[Anurag Phadke[:[e-mail]]]

sorry for the delay in reply, didn't see the flag until now..
Yes, we are ready to go with #1. Once we go live, I will be checking the install ratios by country and keep everyone posted on the progress.

Comment 17

[Alex Keybl [:akeybl]]

Mike/Paul - do you have an ETA now that we have a clear path forward?

Comment 18

[Paul [:pmac] McLanahan]

Just to be clear; we're ready to go with stub for all locales of release on all pages that aren't the /all page and installer-help page. Right? Does this also mean that we've got all locales ready for beta-stub as well?

Comment 19

[Alex Keybl [:akeybl]]

(In reply to Paul McLanahan [:pmac] from comment #18)
> Just to be clear; we're ready to go with stub for all locales of release on
> all pages that aren't the /all page and installer-help page. Right? Does
> this also mean that we've got all locales ready for beta-stub as well?

Yes, we can do both at the same time. Is there any way we can roll this out in the next week? Firefox Team would like to not miss this goal.

Comment 20

[Paul [:pmac] McLanahan]

(In reply to Alex Keybl [:akeybl] from comment #19)

Yes. I should be able to get a PR for this in bedrock by tomorrow and hopefully deployed tomorrow afternoon or thursday. Thanks for the info.

Comment 21

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/617da0c94cb47d3b32c12bdb77faa10af1232e81
Bug 874982: All buttons should offer stub for enabled builds.

Comment 22

[raymond [:retornam] (inactive)]

this is fixed on stage. I was able to download the stub installer file using windows

https://www.allizom.org/en-US/products/download.html?product=firefox-stub&os=win&lang=en-US

Comment 23

[raymond [:retornam] (inactive)]

fixed on prod https://www.mozilla.org/en-US/products/download.html?product=firefox-stub&os=win&lang=en-US


I'll keep checking other parts of the site (especially parts on the old PHP site) for any errors before I marked this as verified.

Thanks everyone

Comment 24

[Paul [:pmac] McLanahan]

Still working on the php side. Patch coming shortly.

Comment 25

[Paul [:pmac] McLanahan]

Attachment: Proposed fix

Comment 26

[Nick Thomas [:nthomas] (UTC+12)]

Could you please confirm that firefox-release-stub is unused ? If so, we'd like to remove it from download.m.o to avoid confusion with firefox-stub.

Comment 27

[Paul [:pmac] McLanahan]

(In reply to Nick Thomas [:nthomas] from comment #26)

I can confirm that none of the code I've added or edited in bedrock or the PHP side of mozilla.org uses firefox-release-stub. We're only using firefox-stub for release channel.

Comment 28

[Osmose [:osmose, :mkelly]]

Comment on attachment 769085 [details] [diff] [review]
Proposed fix

Review of attachment 769085 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 29

[Paul [:pmac] McLanahan]

Committed in r117633.

Comment 30

[Paul [:pmac] McLanahan]

Merged to prod in r117635.

Comment 31

[Robert Strong (they/them - no direct email)]

Can this be resolved -> fixed?

Comment 32

[Robert Strong (they/them - no direct email)]

Just checked and locales aren't being served stub installers yet. Is there an ETA for this?

Comment 33

[Paul [:pmac] McLanahan]

(In reply to Robert Strong [:rstrong] (do not email) from comment #32)
> Just checked and locales aren't being served stub installers yet. Is there
> an ETA for this?

At which button were you looking? I see the es-ES stub being served from the main download page:

http://www.mozilla.org/es-ES/firefox/new/

I believe this is fully done. If there are issues with individual pages I think we should open new bugs.

Comment 34

[Robert Strong (they/them - no direct email)]

Going to http://firefox.com I am redirected to
https://www.mozilla.org/en-US/firefox/fx/

In the above url I then replaced en-US with es-ES which takes me to
https://www.mozilla.org/en-US/firefox/fx/

The button on that page links to
https://www.mozilla.org/es-ES/download/?product=firefox-22.0&os=win&lang=es-ES

which is the full installer.

I'm fine with new bugs though this bug should be resolved fixed then.

Comment 35

[Paul [:pmac] McLanahan]

https://www.mozilla.org/es-ES/firefox/fx/ is still on the old PHP codebase, which apparently isn't using the file I thought it was to build that button. Good catch. We can fix this one in a new bug. There are likely more pages like this on the old pages. I'll see what I can find.

/me files.