875016 - Build break on b2g desktop due to wrong return type in BluetoothServiceChildProcess

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

In code landed in bug 839370, there's a function with a declared return of bool that actually returns an nsresult. This causes build failure on desktop b2g. I'm going to guess this doesn't break on the phone but does break on desktop due to differing toolchain versions, and we don't build bluetooth in our desktop builds on tbpl, so it didn't show up there.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Fix return type for UpdateSdpRecords

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 752867 [details] [diff] [review]
Patch 1 (v1) - Fix return type for UpdateSdpRecords

Review of attachment 752867 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://hg.mozilla.org/projects/birch/rev/6b82e927bcb0

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6b82e927bcb0