875050 - Add EventListenerAdded/Removed to EventTarget

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

https://tbpl.mozilla.org/?tree=Try&rev=9caa7bdadfdd

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: make mTarget EventTarget

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: EventListenerAdded/Removed

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: make WebSocket to use the new stuff

DeviceStorage is kind of odd beast and I didn't have any telephony stuff overriding AddEventListener in my tree.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 752918 [details] [diff] [review]
make mTarget EventTarget

r=me

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 752919 [details] [diff] [review]
EventListenerAdded/Removed

>+    mTarget->EventListenerAdded(aTypeAtom);

Why not do this at the end of the method?  Or at least after we finish touching "ls", just in case some bozo calls RemoveEventListener from EventListenerAdded...

r=me

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 752920 [details] [diff] [review]
make WebSocket to use the new stuff

r=me

The telephony stuff just landed this morning.

Maybe file a followup on that and another one on the fact that devicestorage mishandles on* stuff?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: EventListenerAdded/Removed

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1b21e289bcc
https://hg.mozilla.org/integration/mozilla-inbound/rev/04e8d18e8841
https://hg.mozilla.org/integration/mozilla-inbound/rev/90e77bd04995

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f1b21e289bcc
https://hg.mozilla.org/mozilla-central/rev/04e8d18e8841
https://hg.mozilla.org/mozilla-central/rev/90e77bd04995