875065 - Publish Popcorn Maker projects using make detail design from bug 871727

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Over in bug 871727 Dale implemented the design for the "Make Detail" page, which is the template into which published content will be placed.

Make it so for Popcorn Maker.

Comment 1

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/20

Comment 2

[David Humphrey (:humph)]

Comment on attachment 753461 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/20

A bunch of things in the PR, mostly I want to make sure we get bugs filed on doing the wiring for things that are in the UI of the details but aren't actually implemented and pulling live data.

Also, Travis didn't pass:

## public/css/makedetails.less

public/css/makedetails.less: line 195, col 1, Error - The properties padding-top, padding-bottom, padding-left, padding-right can be replaced by padding.

I've not looked at the CSS/UI at all--I'll leave to Kate.

Comment 3

[inactivate account for kate]

This definitely needs MakeAPI stuff, otherwise I think we should change the fields we are displaying (e.g. author, avatar probably don't make sense) and the layout a bit. Also, let's make sure we are filing a ticket to somehow serve the CSS for thimble/popcorn for this page from the same place.

Another thing I would like to see is Popcorn Maker's colour scheme being carried through. But yeah, this generally looks good to land

Comment 4

[Matthew Schranz [:mjschranz]]

Comment on attachment 753461 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/20

I've fixed the UI bits related to code that Kate brought up and Humphs review nits.

I've filed a bug about stripping out the rest of the static elements there. Do I have the green light to land this as is?

Comment 5

[Brett Gaylor [:brett]]

Land and lets iterate.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/4bf2f2905bd0d8d8fb8ff5f21144358166d8709e
Fix Bug 875065 - Initial version of Make Details page in Popcorn Maker