875089 - tutorial button was a casualty of the new user bar styling

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Pomax]

The snippet for the user bar changed, it's possible that the tutorials button/link was a casualty of this change. We'll have to verify that it's either still there, or put it back in.

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/75

Just a quick plug in.

I believe this is going to be moved again, into the second nav. So, probably not worth worrying too much about it, imo.

Comment 2

[Pomax]

Comment on attachment 753021 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/75

few points in the pull request; added Ross for a feedback request about the placement of the tutorial link (all the way on the left's probably not good placement)

Comment 3

[Pomax]

would now be a good time to also take that JS for tutorials out and put it in its own file?

Comment 4

[Scott [:thecount] Downe]

Eh, I'm not too concerned about that tbh. I'm thinking it works as is, would be nice to be better, but would rather focus on things that don't exist.

That being said, I would be willing to review what you're requesting, so, new ticket?

Also, we might want to worry about that once we've got a second header?

Comment 5

[Pomax]

Comment on attachment 753021 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/75

kk, let's land this then. do we have a followup bug for the 2nd bar already?

Comment 6

[Scott [:thecount] Downe]

Filed here bug 875429

Staged: https://github.com/mozilla/thimble.webmaker.org/commit/d1fba8c4d3898be10a2290b381e00b9c99aa7431