tutorial button was a casualty of the new user bar styling

RESOLVED FIXED

Status

Webmaker
Thimble
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: pomax, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
The snippet for the user bar changed, it's possible that the tutorials button/link was a casualty of this change. We'll have to verify that it's either still there, or put it back in.
(Assignee)

Comment 1

5 years ago
Created attachment 753021 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/75

Just a quick plug in.

I believe this is going to be moved again, into the second nav. So, probably not worth worrying too much about it, imo.
Attachment #753021 - Flags: review?(pomax)
(Reporter)

Comment 2

5 years ago
Comment on attachment 753021 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/75

few points in the pull request; added Ross for a feedback request about the placement of the tutorial link (all the way on the left's probably not good placement)
Attachment #753021 - Flags: review?(pomax)
Attachment #753021 - Flags: review-
Attachment #753021 - Flags: feedback?(ross)
(Assignee)

Updated

5 years ago
Attachment #753021 - Flags: review- → review?(pomax)
(Reporter)

Comment 3

5 years ago
would now be a good time to also take that JS for tutorials out and put it in its own file?
(Assignee)

Comment 4

5 years ago
Eh, I'm not too concerned about that tbh. I'm thinking it works as is, would be nice to be better, but would rather focus on things that don't exist.

That being said, I would be willing to review what you're requesting, so, new ticket?

Also, we might want to worry about that once we've got a second header?
(Reporter)

Comment 5

5 years ago
Comment on attachment 753021 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/75

kk, let's land this then. do we have a followup bug for the 2nd bar already?
Attachment #753021 - Flags: review?(pomax)
Attachment #753021 - Flags: review+
Attachment #753021 - Flags: feedback?(ross)
(Assignee)

Comment 6

5 years ago
Filed here bug 875429

Staged: https://github.com/mozilla/thimble.webmaker.org/commit/d1fba8c4d3898be10a2290b381e00b9c99aa7431
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.