875091 - [traceback] AttributeError: 'NoneType' object has no attribute 'get_features' - Rejected apps 500 on `get_features`

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Rob Hudson [:robhudson]]

http://sentry.dmz.phx1.mozilla.com/addons/marketplace-dev/group/14248/

We're using `addon.current_version.get_features().to_list()` and rejected apps current_version is None.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

mkt.developers.views in edit
AttributeError: 'NoneType' object has no attribute 'get_features'

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "newrelic/api/object_wrapper.py", line 216, in __call__
    self._nr_instance, args, kwargs)
  File "newrelic/hooks/framework_django.py", line 475, in wrapper
    return wrapped(*args, **kwargs)
  File "amo/decorators.py", line 157, in wrapper
    return f(*args, **kw)
  File "amo/decorators.py", line 149, in wrapper
    return f(*args, **kw)
  File "python2.6/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)
  File "amo/models.py", line 38, in skip_cache
    yield
  File "amo/decorators.py", line 149, in wrapper
    return f(*args, **kw)
  File "addons/decorators.py", line 33, in wrapper
    return f(request, addon, *args, **kw)
  File "amo/decorators.py", line 32, in wrapper
    return func(request, *args, **kw)
  File "mkt/developers/decorators.py", line 65, in wrapper
    return fun()
  File "mkt/developers/decorators.py", line 28, in <lambda>
    *args, **kw)
  File "mkt/developers/views.py", line 132, in edit

Comment 2

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/pull/780

Comment 3

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/c25717501c505076f285dc987bd543bfb78a45d1

To reproduce, you need to disable/delete your latest available version so that your latest version either do not exist or is disabled/rejected/etc. Then go to the edit listing page, and it should be working with the features stuff hidden (*).

(*) requires waffle switch 'buchets' active to test.