project remix urls are broken

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The makes in the my makes tab do not properly load thimble remix pages.

This is because the remix url, and the publish url at the moment are not alike.

Example:
Publish:
https://scottdowne.s3.amazonaws.com/scott/thimble/your-awesome-webpage-created-on-wed-22-may-2013-210424-gmt
Remix:
http://localhost:3500/remix/3/edit

With localhost being whatever domain, in most cases it'll be something like thimble.webmaker or something.

So, adding a /edit to the end of the publish url isn't enough anymore.

On top of that, I see both these urls changing.

I think the easiest way to solve this is to simply let the tool store a publish url (it already does) and a remix url (I'm cool with this living in a tag for now, but ideally it would have its own attribute in the api)

Like I said, this is the easiest solution. All the apps at this time can know the publish and remix, and asking the dispplaying app to guess or create the remix url to me seems fragile.

The changes on webmaker.org side would simply be to check for the remix url and use it in the dashboard instead of appending /edit.

This also has the advantage of not having to guess between differences between the way popcorn and thimble generate remix urls.
(Assignee)

Updated

6 years ago
Assignee: nobody → scott

Comment 1

6 years ago
See https://bugzilla.mozilla.org/show_bug.cgi?id=869960 as well, where we discussed the idea of a remixURL attribute being added to the MakeAPI.
(Assignee)

Updated

6 years ago
Depends on: 875322
(Assignee)

Comment 2

6 years ago
Created attachment 753316 [details] [review]
https://github.com/mozilla/webmaker.org/pull/26
Attachment #753316 - Flags: review?(schranz.m)
Attachment #753316 - Flags: review?(jon)
Attachment #753316 - Flags: review?(chris)

Comment 3

6 years ago
where is the bug that addresses the /edit issue for Thimble? can you add that as one of the "see also..." bugs?

Updated

6 years ago
Attachment #753316 - Flags: review?(jon) → review+

Updated

6 years ago
Attachment #753316 - Flags: review?(schranz.m)
Attachment #753316 - Flags: review?(chris)
(Assignee)

Comment 4

6 years ago
bug 875100 is the thimble bug for this.

This could of also been found by looking at other dependencies of the blocking bug for this.
(Assignee)

Comment 5

6 years ago
Staged: https://github.com/mozilla/webmaker.org/commit/fb484f9506ad20df4234ce373959d22b6393f95f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.