875096 - [Traceback] Bad pluralization in SL localization

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect, P1)

Description

[Michael Cooper [:mythmon]]

SVN revision r116236 introduced an error the pluralization of the javascript.po file for the SL locale. In locales/sl/LC_MESSAGES/javascript.po :

    -"Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || n%100==4 ? 2 : 3);\n"
    +"Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || n%100==4. 2 : 3);\n"

In particular, a "?" in a ternary operator was changed to a ".". I don't have SVN commit access to fix this. The fix is to revert the diff above.

Related to: https://errormill.mozilla.org/support/support/group/15845/ .


Internal Server Error: /sl/jsi18n/build:6479a3b

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "newrelic/api/object_wrapper.py", line 216, in __call__
    self._nr_instance, args, kwargs)
  File "newrelic/hooks/framework_django.py", line 475, in wrapper
    return wrapped(*args, **kwargs)
  File "django/utils/decorators.py", line 91, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "django/views/i18n.py", line 238, in javascript_catalog
    catalog = gettext_module.translation(domain, path, [locale])
  File "python2.6/gettext.py", line 480, in translation
    t = _translations.setdefault(key, class_(open(mofile, 'rb')))
  File "python2.6/gettext.py", line 180, in __init__
    self._parse(fp)
  File "python2.6/gettext.py", line 317, in _parse
    self.plural = c2py(plural)
  File "python2.6/gettext.py", line 126, in c2py
    return eval('lambda n: int(%s)' % plural)

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

I fixed here:
http://viewvc.svn.mozilla.org/vc/projects/sumo/locales/sl/LC_MESSAGES/javascript.po?r1=116236&r2=116298

I'll deploy now to refresh strings. We need the sl strings to be updated on the Verbatim side.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Making this 1pt, mostly for the time mythmon spend figuring it out.