875099 - Avoid including MDDEPEND_FILES twice

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Some .deps files are included twice, and that contributes greatly to pymake being slow especially under dom/bindings.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Allow recursive calls in pymake

Comment 2

[Mike Hommey [:glandium]]

Attachment: Avoid including MDDEPEND_FILES twice

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 752979 [details] [diff] [review]
Avoid including MDDEPEND_FILES twice

Review of attachment 752979 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/rules.mk
@@ +1615,5 @@
>  #   dependency directory in the object directory, where we really need
>  #   it.
>  
>  ifneq (,$(filter-out all chrome default export realchrome tools clean clobber clobber_all distclean realclean,$(MAKECMDGOALS)))
> +uniq = $(if $1,$(firstword $1) $(call uniq,$(filter-out $(firstword $1),$1)))

Should just use $(sort) here, as that gives you unique results.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 752977 [details] [diff] [review]
Allow recursive calls in pymake

Review of attachment 752977 [details] [diff] [review]:
-----------------------------------------------------------------

If you use $(sort) you shouldn't need this, right?

Comment 5

[Mike Hommey [:glandium]]

Attachment: Avoid including MDDEPEND_FILES twice

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 752977 [details] [diff] [review]
Allow recursive calls in pymake

Not needed anymore.

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87af5e1caacb

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/87af5e1caacb