Closed
Bug 875100
Opened 12 years ago
Closed 12 years ago
Thimble projects should save the remix url in the makeapi
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: thecount, Assigned: thecount)
References
Details
Attachments
(1 file)
This is the other end of bug 875095.
I feel we should store the remix url in the makeapi. I am ok with making this a tag.
We need this because inside the dashboard, the remix url is being guessed or recreated.
This also has the advantage of not having to guess between differences between the way popcorn and thimble generate remix urls.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → scott
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #753315 -
Flags: review?(pomax)
Comment on attachment 753315 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/76
looks good.
Attachment #753315 -
Flags: review?(pomax) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Staged: https://github.com/mozilla/thimble.webmaker.org/commit/0bf0a1e1ba8a7fe1bcc03d12112619da3d37c0e6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•