87516 - Send Message Progress-Bar (in the statusbar) should show "Progress" (and not just a barber pole)

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Peter Lairo]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.1+) Gecko/20010622

Send Message Progress Bar should show "Progress" (and not just a barber pole).

This is particularly useful for messages with attachments.

Comment 1

[Boris Zbarsky [:bzbarsky]]

ccing hwaara.  Hakan, isn't this a dup of one of your bugs?

Comment 2

[Håkan Waara]

Nope. But it might be a dup of any of ducarroz's bugs.

-> Composition

Comment 3

[Francisco León]

this should be dup of bug 86393

Comment 4

[Peter Lairo]

NO, not a dupe, because this bug means the progress bar in the *status bar* (and
not in the extra window, which would have made this bug a wontfix, not a dupe).
Sorry for not being more clear in the summary -> changing.

Comment 5

[Christian Koch]

*** This bug has been confirmed by popular vote. ***

Comment 6

[Jeff Hooker]

adding keyword nsenterprise

Comment 7

[scottputterman]

reassigning to ducarroz.  I think this might be fixed.

Comment 8

[Jean-Francois Ducarroz]

during a send/save operation, the status bar show exactly the same status than
the send/save progress dialog. I don't understand why this bug get open! Peter,
can you explain exactly what's the problem. Thanks

Comment 9

[Peter Lairo]

Progress-bar, as in: *a bar that increases in size* as more and more of the
message is transmitted.

Like this:
 10% #
 20% ##
 50% #####
100% ##########
Not like this:
////////////// (rotating stripes)

Comment 10

[Peter Lairo]

BTW, I only care about the *statusbar*. I could care less about the unnecessary
and poor UI design decision of the "send progress dialog" (which should be
abolished anyways). :|

Comment 11

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v1

Comment 12

[varada]

Should we have a common function for the calculations of the progress-bar
status?. We seem to have similar code in lots of places throughout the product.
Other than that - r=varada

Comment 13

[(not reading, please use [e-mail] instead)]

+      var overallProgress = aCurTotalProgress;

why define this?  just use aCurTotalProgress in your function

+      if ( aMaxTotalProgress != "-1" ) 

is aMaxTotalProgress a string, or an int, or both?  do some callers call
onProgressChange() with a string and some with an int?

Comment 14

[(not reading, please use [e-mail] instead)]

varada, that code is sprinkled all over, but mostly I've seen it in C++.  does
it exist anywhere else in JS?

Comment 15

[Jean-Francois Ducarroz]

I copied this code from the progress dialog JS and modified it. The problem with
JS is that even if we try to put into a common file, JS will still have to
compile it each time we use it therefore they will be no speed gain but rather
even a degradation as JS need to open an extra file.

Comment 16

[Jean-Francois Ducarroz]

Attachment: proposed fix, v2

Comment 17

[Sheela Ravindran]

change to myself 

Comment 18

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 19

[Peter Lairo]

I sure hope this checkin fixes the *Statusbar* and not just that useless extra
"status window". ;)

Comment 20

[Sheela Ravindran]

verified, send progress in the status bar is same as the in the send progress dlg

2001-08-13-06 win98
2001-08-13-04 mac
2001-08-13-06 linux