Closed Bug 875165 Opened 8 years ago Closed 8 years ago

Update help button style to be compatible with XBL refactoring changes.

Categories

(Toolkit :: Themes, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: wchen, Assigned: wchen)

References

Details

Attachments

(1 file)

There is a big XBL refactoring effort (bug 653881) that causes some changes in behavior. Currently, <xbl:children> elements are removed from the binding and is not visible when traversing the tree, after the refactoring we leave the <xbl:children> elements where they are. e.g.

<binding id="example">
  <content>
    <children>
      <span class="red">Hello</span>
    </children>
  </content>
</binding>

<div style="-moz-binding("#example")></div>

In the current world, the tree looks like this:
<div>
  <span>
    #Hello

After the refactoring, the tree looks like this:
<div>
  <children>
    <span>
      #Hello

This causes problems for style selectors using the child combinator (>) because there is a new element in the hierarchy that will cause the selector to not match some elements that did match prior to the refactoring. The help button in the preferences dialog runs into this problem.
Did you find this with some automated analysis? Is this the only case you found and if so, are you confident that there are no others?
(In reply to Dão Gottwald [:dao] from comment #2)
> Did you find this with some automated analysis? Is this the only case you
> found and if so, are you confident that there are no others?

No, I did not use any automated tools to find this. I've investigated methods for trying to detect affected instances but I have not found a good solution. So far this is the only case found that breaks due to the styling issue mentioned. I'm not confident there are no others. Hopefully this is rare enough that we can fix any of the styling problems that arise on a case by case basis after landing the refactoring.
Blocks: 653881
Comment on attachment 753061 [details] [diff] [review]
Update help button style to be compatible with XBL refactoring changes.

Please use xbl|children instead of xbl|*.
Attachment #753061 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/8f33bb32e924
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Target Milestone: mozilla25 → ---
You need to log in before you can comment on or make changes to this bug.