875188 - Add a variant for importPKCS12File

Status: RESOLVED WONTFIX

(Core :: Security: PSM, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Currently nsIX509CertDB.importPKCS12File will invoke some XUL dialog to get password for the PKCS12 file, but on B2G we try to avoid use XUL here.

So we need to create another variant for importPKCS12File, either
1. Add another parameter for password.
2. Dispatch some browser element (for dialog) event to Gaia and let Gaia handle the UI part for inputing password.

Please also see the previous discussing thread on dev-b2g. [1]


[1]: https://groups.google.com/forum/#!msg/mozilla.dev.b2g/YKUBFge_qxc/LQJYv9CU3YIJ

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, Brian
Does the new method should be in nsIX509CertDB2.idl?

From nsIX509CertDB2.idl I saw the comment
/**
 * This represents a service to access and manipulate 
 * X.509 certificates stored in a database through methods
 * not in nsIX509CertDB, which is *frozen*
 *
 */

By frozen does it we cannot modify nsIX509CertDB.idl?

Thanks

Comment 2

[Masatoshi Kimura [:emk]]

The comment is obsolete. All interfaces are unfrozen since Firefox 4.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Add password for importPKCS12File

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Try https://tbpl.mozilla.org/?tree=Try&rev=4958128c43b1

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 759672 [details] [diff] [review]
Add password for importPKCS12File

Hi, Brian
Can you review this patch with additinal password parameter for importPKCS12File for me ?

Thanks

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, bsmith, review ping?
Or if the patch is wrong in somethere, feel free to tell me and cancel r?. :)

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 759672 [details] [diff] [review]
Add password for importPKCS12File

Canceling r? as I think for Web it should use prompt to get the password if needed.

I should try if we could create another component like NSSDialog on B2G.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Remove 1.3+ and Target Mile Stone for we will do this in Wifi, Bug 917102.

Comment 9

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

This would be a great way to move towards PSM code not causing any dialogs to open.