[Settings] FxOS Bluetooth Pairing Dialog should take passwords longer than 4 numbers

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: arthurcc, Assigned: johnhu)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(b2g18 unaffected, b2g18-v1.0.1 unaffected)

Details

Attachments

(1 attachment)

The issue has been fixed in bug 849365 but regressed by the patch of bug 855076. 

Pincode should be a 1 to 16 characters long string. The characters range from 0x00 to 0x7F.
Since the patch of bug 855076 only landed on gaia master, v1-train and v1.0.1 are unaffected.
Assignee: nobody → johu
Created attachment 753609 [details]
patch for this bug

change the input type to text and length to 16.
Attachment #753609 - Flags: review?(arthur.chen)
Comment on attachment 753609 [details]
patch for this bug

Thanks! r=me.
Attachment #753609 - Flags: review?(arthur.chen) → review+
merged to master: 

https://github.com/mozilla-b2g/gaia/commit/7116552fc4875d439a5cd15e694da4861f3e0fe9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You will have to change the patch : 
        <span id="pin-input-method" hidden>
          <input type="number" id="pin-input" size="4" maxlength="4" /> 

and update it, otherwise you will end up reverting the issue back.  Can you update the patch please?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oops. wrong bug.  ignore last comment please
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.