875265 - [Cost Control] Invalid ICCID check handling in Gaia Usage app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P1)

Description

[Leo]

1. Title : Invalid ICCID check handling in Gaia Usage app.
2. Precondition : Enable SIM lock
3. Tester's Action : Usage->Browse the internet using SIM->Reboot the device->Enter the SIM pin and Check the logs of the Usage app
4. Detailed Symptom (ENG.) :Even SIM is ready case also window.navigator.mozMobileConnection.iccInfo.iccid is returning ICCID either null or ''(empty string)
6.Reproducibility: Y
1)Frequency Rate : 100%\
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 61d7ab244db3e2174b22bfa6de3e3d69136b4904
9.Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: Invalid ICC ID patch

Comment 2

[Leo]

This bug is follow up of bug-868363.

Comment 3

[Salvador de la Puente González [:salva]]

Comment on attachment 753221 [details] [diff] [review]
Invalid ICC ID patch

Review of attachment 753221 [details] [diff] [review]:
-----------------------------------------------------------------

Please Sireesha, instead of uploading a patch, make a PR on GitHub and upload an HTML redirecting to the PR page (when uploading the HTML, mark the former as obsolete).

Comment 4

[Leo]

Attachment: Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/9959

Hi,

Please review the pull request and provide your comments.

Thanks,
Leo

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 753247 [details]
Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/9959

Hello Sireesha, please review the comments in GitHub, solve the problems and ask for review once all are solved.

Comment 6

[Leo]

Comment on attachment 753247 [details]
Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/9959

Review changes are squashed.Please review it.

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 753247 [details]
Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/9959

Note this is a case I can not reproduce but the code looks perfect for me.
Thank you very much Sireesha!

Comment 8

[Salvador de la Puente González [:salva]]

Master: f23775cbac7036635ac0f30dad1b84b62807f65f

Comment 9

[Salvador de la Puente González [:salva]]

Comment on attachment 753247 [details]
Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/9959

Bug caused by (feature/regressing bug #): none
User impact if declined: moderate (if it happens, the application crashes)
Testing completed: in process by Leo (asking for qawanted and needinfo)
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 10

[Salvador de la Puente González [:salva]]

Sireesha, can you confirm did you tested this patch completely? Once confirmed, remove the qawanted keyword.

Comment 11

[Leo]

Monday i will update the test results.

Comment 12

[Leo]

Attachment: Reference logs attached with Invalid ICCID Handling

Comment 13

[Leo]

Hi Salva,

I tested in Leo and changes are fine.I attached logs for reference.
If you have time please review once.
The logs are fine for me.If you fine any costcontrol flow/execution errors in logs
please let me know.

Thank You for your support.
Sireesha

Comment 14

[Salvador de la Puente González [:salva]]

Comment on attachment 753247 [details]
Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/9959

Logs seem OK for me.

Bug caused by (feature/regressing bug #): none
User impact if declined: medium
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 15

[Alex Keybl [:akeybl]]

Comment on attachment 753247 [details]
Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/9959

After reviewing the code, this is a good low risk fix.

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted f23775cbac7036635ac0f30dad1b84b62807f65f to:
v1-train: 89ecda3dc7516b13d24c635538c34db9e3d8f34c