bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

[traceback] KeyError: u'source_url' (/sq/about)

RESOLVED FIXED

Status

Input Graveyard
Code Quality
P1
normal
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: willkg, Unassigned)

Tracking

Details

(Whiteboard: u=user c=dashboard p= s=input.2013q2)

Bad l10n strings causing the page to ISE.


Traceback (most recent call last):

  File "/data/www/input.mozilla.org/input/vendor/lib/python/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/usr/lib64/python2.6/site-packages/newrelic-1.11.0.55/newrelic/api/object_wrapper.py", line 216, in __call__
    self._nr_instance, args, kwargs)

  File "/usr/lib64/python2.6/site-packages/newrelic-1.11.0.55/newrelic/hooks/framework_django.py", line 475, in wrapper
    return wrapped(*args, **kwargs)

  File "/data/www/input.mozilla.org/input/vendor/src/django-mobility/mobility/decorators.py", line 23, in wrapper
    return f(request, *args, **kw)

  File "/data/www/input.mozilla.org/input/fjord/base/views.py", line 28, in about_view
    return render(request, template)

  File "/data/www/input.mozilla.org/input/vendor/lib/python/django/shortcuts/__init__.py", line 44, in render
    return HttpResponse(loader.render_to_string(*args, **kwargs),

  File "/data/www/input.mozilla.org/input/vendor/lib/python/django/template/loader.py", line 176, in render_to_string
    return t.render(context_instance)

  File "/data/www/input.mozilla.org/input/vendor/src/jingo/jingo/__init__.py", line 189, in render
    return super(Template, self).render(context_dict)

  File "/usr/lib64/python2.6/site-packages/newrelic-1.11.0.55/newrelic/api/object_wrapper.py", line 216, in __call__
    self._nr_instance, args, kwargs)

  File "/usr/lib64/python2.6/site-packages/newrelic-1.11.0.55/newrelic/api/function_trace.py", line 82, in dynamic_wrapper
    return wrapped(*args, **kwargs)

  File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/www/input.mozilla.org/input/fjord/base/templates/about.html", line 1, in top-level template code
    {% extends "base.html" %}

  File "/data/www/input.mozilla.org/input/fjord/base/templates/base.html", line 63, in top-level template code
    {% block content %}{% endblock %}

  File "/data/www/input.mozilla.org/input/fjord/base/templates/about.html", line 9, in block "content"
    {% include "includes/about_text.html" %}

  File "/data/www/input.mozilla.org/input/fjord/base/templates/includes/about_text.html", line 32, in top-level template code
    {% trans url='https://github.com/mozilla/fjord' %}

  File "/usr/lib64/python2.6/site-packages/jinja2/_markupsafe/__init__.py", line 98, in __mod__
    return self.__class__(unicode.__mod__(self, arg))

  File "/usr/lib64/python2.6/site-packages/jinja2/_markupsafe/__init__.py", line 212, in <lambda>
    __getitem__ = lambda s, x: _MarkupEscapeHelper(s.obj[x])

KeyError: u'source_url'
Milos: There are a few bad strings in the various locales where they've either added Python formatting tokens that shouldn't be there or misspelled them.

These are a big deal since they cause the pages in question to throw an HTTP 500 error, so I'd like to have a process that allows me to fix them quickly.

How should we do that?

Should the process be that I go into Verbatim, find the string and fix it?

I'm a monoglot, so "fix it" probably entails me making it unreadable in the language it's in.
Flags: needinfo?(milos)

Comment 2

5 years ago
Will,

We could have you do it, or you ping me and I ping localizers to fix it in a timeframe, given we know about errors before they get to production. If localizers don't make it before the deadline, we'll just change it so that it doesn't spit any errors, and worry about translation quality later.
Flags: needinfo?(milos)
Milos: I need to fix a couple of strings now but I don't seem to have access to do it in Verbatim.

https://localize.mozilla.org/ko/input/LC_MESSAGES/translate.html?unit=1417420

"feedback_url" needs to be changed to "url"

https://localize.mozilla.org/sq/input/LC_MESSAGES/translate.html?search=source_url&sfields=source&sfields=target

"source_url" needs to be changed to "url"
Flags: needinfo?(milos)
Bug #875313 covers reworking the deployment system so that we're not updating strings automatically without checking them first.
Making this a P1 for this sprint--needs to be fixed as soon as we can.
Priority: -- → P1
Whiteboard: u=user c=dashboard p= s=input.2013q2
Milos: Can you help me with comment #3?

Comment 7

5 years ago
Fixed in r116589/r116590.
Flags: needinfo?(milos)
Looks fixed now.

Thanks Milos!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.