Closed
Bug 875292
Opened 12 years ago
Closed 12 years ago
Fire collectNodes as early as possible
Categories
(L20n :: HTML Bindings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: stas)
Details
Attachments
(1 file)
|
782 bytes,
patch
|
zbraniecki
:
review+
|
Details | Diff | Splinter Review |
Right now in bootstrap, we do the following:
document.addEventListener('readystatechange', collectNodes);
If, for some reason, this line runs after DOMContentLoaded fires (e.g. when using require.js), we wait until readyState changes to 'complete', instead of calling callectNodes right away.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → stas
Attachment #753259 -
Flags: review?(gandalf)
|
|
Assignee | |
Comment 2•12 years ago
|
||
See https://github.com/fabi1cazenave/webL10n/issues/30 and https://github.com/fabi1cazenave/webL10n/pull/31 for a related bug in webL10n. Admittedly, I'm not sold on the idea of using <script defer> for doing localization in production. However, the same problem exists if you use AMD (require.js) without optimization (e.g. for development).
|
||
Updated•12 years ago
|
Attachment #753259 -
Flags: review?(gandalf) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•