875310 - storage _getList will trigger undefined and not properly call callback

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[oscar.amat.caro]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.65 Safari/537.31

Steps to reproduce:

Checking the project's usage of IndexedDB I stumbled with this pretty straightforward error.


Actual results:

In call_log_db.js, there is a _getList method that contains:

cursor.onerror = function(event) {
        if (callback && callback instanceof Function) {
          callback(e.target.error.name);
        }
      };

It triggers undefined exception whenever an error happens.


Expected results:


cursor.onerror = function(event) {
        if (callback && callback instanceof Function) {
          callback(event.target.error.name);
        }
      };

Comment 1

[oscar.amat.caro]

Attachment: PR link in github

Link to PR in github: https://github.com/mozilla-b2g/gaia/pull/9963

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Thanks Oscar! Nice catch.

This patch needs to be uplifted to v1-train as a follow-up of bug 870359 and bug 847404

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/5a6b600c5c609291d176f2c23f623ae8888e0ac3

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Please nominate for uplift with a risk evaluation.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 753277 [details]
PR link in github

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 847404
User impact if declined: None, but logcat exception message.
Testing completed: Unit tests and functionality tests.
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.