Closed Bug 875366 Opened 11 years ago Closed 3 years ago

Make dir listings mobile friendly

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P5)

All
Android
defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: wesj, Unassigned)

References

Details

(Whiteboard: [lang=css][lang=C++][bad-first-bug])

Attachments

(3 files)

Attached image Screenshot
I would be nice if file/ftp listings were mobile/touch friendly.
Attached patch WIP PatchSplinter Review
(In reply to Wesley Johnston (:wesj) from comment #1)
> Created attachment 753324 [details] [diff] [review]
> WIP Patch

Is the screenshot from your WIP? If not, can you add one?
It is! There's some harder to solve problems here.

For instance, tapping on "Name" will show you sort options as a little pop-over menu, which you can tap to toggle the sort (I also made the size or date columns show when you're sorting by them, although that's a bit ugly right now). But I used :hover to show the menu (maybe I could switch to :focus...) which means it doesn't go away until you tap off it. That works, but is really unintuitive. Perhaps for now we're better to just hide the sorting options.

The up button also appears/disappears in the top left depending on if you can go up or not, but seems to have problems with ordering (I think you wind up clicking on the row underneath it if you've scrolled.

Lots of details. Marking this as a mentor bug. Happy to help someone if they want it, but beware that it may take a few design iterations to work out these issues, and since some of this code is in C++, you may have to do some (relatively simple?) work there.
Whiteboard: [mentor=wesj][lang=css][lang=C++][bad-first-bug]
Wesley, I'll gladly give this bug a shot. I tried to apply the attached patch but its not giving me the results as displayed on the screenshot. Where should I start?
By "not the results as displayed on the screenshot" do you mean nothing's changed at all, or just that they don't look like the screenshot? Looking at that patch, I think I dropped some code I had written. I can try and dig up the right patch, but its in a backup harddrive I'll have to look into tonight. Alternatively, you can do your own edits.

I think a much better way to do this may be to write our own version of:

http://mxr.mozilla.org/mozilla-central/source/netwerk/streamconv/converters/nsIndexedToHTML.h

Maybe in JS, but I'm not quite sure how nsIndexedToHTML works either, so I'm not sure if its possible.
For me it looks like this: tiny. No patch applied. Is this normal?
(In reply to Adrian May [:adrianmay] from comment #7)
> Created attachment 788022 [details]
> Screenshot_2013-08-09-12-22-55.png
> 
> For me it looks like this: tiny. No patch applied. Is this normal?

Yes, the state of this bug is still open.
Mentor: wjohnston
Whiteboard: [mentor=wesj][lang=css][lang=C++][bad-first-bug] → [lang=css][lang=C++][bad-first-bug]
OS: Linux → Android
Hardware: x86_64 → All
Hi, I am new to fixing bugs and I would like to work on the bug please.
Mentor: wjohnston2000
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: -- → P5
See Also: → 1530358
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: