Closed Bug 875372 Opened 11 years ago Closed 11 years ago

DeviceStorage: Add missing return statement in AddNamed function

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla24
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix

People

(Reporter: dhylands, Assigned: dhylands)

References

Details

(Keywords: crash, Whiteboard: [b2g-crash][fixed-in-brich])

Crash Data

Attachments

(1 file, 1 obsolete file)

Add missing return to AddNamed when a non-existant storage name is used v2
1.46 KB, patch
dougt
: review+
Ms2ger
: feedback+
Details | Diff | Splinter Review 
Ms2get noticed that there was a return missing in the AddNamed function when a non-existant composite device storage area was specified.

Without the missing return, it will cause a segfault.

This bug was introduced as part of bug 858416.
Edited the correct file this time.
Attachment #753339 - Attachment is obsolete: true
Comment on attachment 753341 [details] [diff] [review]
Add missing return to AddNamed when a non-existant storage name is used v2

I checked all of the places that NS_DispatchToMainThread() and IsComposite() were called, just to make sure that there weren't any similar oversights elsewhere.
Attachment #753341 - Flags: review?(Ms2ger)
Comment on attachment 753341 [details] [diff] [review]
Add missing return to AddNamed when a non-existant storage name is used v2

Review of attachment 753341 [details] [diff] [review]:
-----------------------------------------------------------------

Looks sane to me.
Attachment #753341 - Flags: review?(doug.turner)
Attachment #753341 - Flags: review?(Ms2ger)
Attachment #753341 - Flags: feedback+
Comment on attachment 753341 [details] [diff] [review]
Add missing return to AddNamed when a non-existant storage name is used v2

><
Attachment #753341 - Flags: review?(doug.turner) → review+
Crash Signature: [@ nsDOMDeviceStorage::AddNamed ]
Severity: normal → blocker
Keywords: crash
Whiteboard: [fixed-in-brich] → [b2g-crash][fixed-in-brich]
https://hg.mozilla.org/mozilla-central/rev/d421793b8c49
Assignee: nobody → dhylands
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
I'm marking this as leo+ since crashes have been reported in b2g18 which are caused by this, and this was introduced by bug 858416, which is leo+.
blocking-b2g: leo? → leo+
Flags: in-moztrap?
Flags: in-moztrap?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: