875451 - Enable dynamic menu access for testAddBookmarkToMenu.js

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Jonathan French (:jfrench)]

Begat from but outside the scope of cleanup bug 873473, testAddBookmarkToMenu.js appears it can have its places API call retired and instead directly issue a click event in the bookmark's dynamic menu - now that bug 474486 is fixed.

See the comment at the bottom of the test, for the block to be modified.

tests/functional/testBookmarks/testAddBookmarktoMenu.js

Comment 1

[Jonathan French (:jfrench)]

If it's not an urgent fix I'm going to put this one in my to do queue.

Comment 2

[Jonathan French (:jfrench)]

So after some bug forensics and digging, I think testAddBookmarkToMenu.js can't be fixed in the way its comment below implies, even though the referenced bug is marked fixed.

> // Bug 474486
> // Until we can't check via a menu click, call the Places API function for now

That comment was added to the test on its creation 2009-02-03 understandably after bug 474486 was opened, but before it was fixed. Makes sense so far.
http://hg.mozilla.org/qa/mozmill-tests/rev/e583d3079dad

Some months later, bug 474486 was fixed. Note: a split off bug was created for a remaining issue, and is still open, bug 583379, referenced here:

https://bugzilla.mozilla.org/show_bug.cgi?id=474486#c35
"The down side is that this means we won't be able to retrieve dynamic content from these specific menus (such as the 'History' menu)."

Years _after bug 474486 was fixed, 3 new /endurance bookmark tests were created; in 2011, and 2012 respectively. All appeared to use, and continue to use places API.

testBookmarks_AddAndRemoveBookmarkViaAwesomeBar (created: 2012-02-07)
testBookmarks_OpenAllInTabs (cretaed: 2011-12-14)
testBookmarks_OpenAndClose (created: 2012-07-27)

Since they were all created after, and they used places API, logic says there wasn't another solution (I think).

So I propose that this bug be changed to either just remove the stated comment, or change its reference to bug 583379 if that is appropriate.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

A lot might have been changed in terms of menu access in the past couple of months. I can remember that we even have the possibility to handle the main menu on OS X now. I have seen something like that a couple of days ago. Sorry, I don't actually have the bug number around. So it might be that also other stuff got fixed, which might help us to get to what we want here.

We should try if we can get the menu API working with dynamic sub menus. If we are still blocked by something we would know better, and still have to wait.

Comment 4

[Jonathan French (:jfrench)]

I've got a bunch of other stuff on the go right now and this bug has languished in my queue for months, so I'm going to un-assign myself in case someone else wants to have a go at it.

Comment 5

[multhazim123]

Hello,

I would be interested in taking on this bug. I have a development environment already deployed and would appreciate any mentorship if possible. I am planning to submit a patch by March 26.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Actually mozmill is dead. So this bug is no longer necessary. As test framework we moved to Marionette where we have similar things to do now, but in Python and not JS. Let us know on bug 1121710 if you have interest.

I will close this bug as wontfix.