875468 - B2G Emulator-x86: undefined reference to `vgSysWrap_xen_hypercall_before' and 'vgSysWrap_xen_hypercall_after'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

Attachment: b2g build errors

Bug 854517 integrated valgrind into B2G but fails emulator-x86 build.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Oops. Looks like a syswrap_xen.c got added that I forgot to include in the makefile. Will build against a few targets to make sure I got it fixed, then patch.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Add syswrap-xec.c to valgrind Android.mk

I built againt emuluator-x86, emulator, and unagi with this patch, all seem to at least build now.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 753496 [details] [diff] [review]
Patch 1 (v1) - Add syswrap-xec.c to valgrind Android.mk

Review of attachment 753496 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me!

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://github.com/mozilla-b2g/valgrind/commit/18681654cb7b32d544f80a07573025dbc841aa74