Closed
Bug 875473
Opened 11 years ago
Closed 11 years ago
Add saveFrameChain option to shell evaluate function
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
3.19 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
evalInFrame() has a |save| argument and when it's set we call JS_SaveFrameChain/JS_RestoreFrameChain before/after the eval-in-frame. However, when evalInFrame is used, ScriptFrameIter always "sees through" saved frame chains, for instance the following script will print all frames: setDebug(true); function g() { print(Error().stack); } function f() { evalInFrame(0, "g()", true); } f(); As far as I can tell there's no way to test the usual behavior of ScriptFrameIter stopping when it reaches a "saved frame chain". The attached patch adds a saveFrameChain option to the shell's evaluate function and adds a test for it.
Attachment #753452 -
Flags: review?(luke)
Updated•11 years ago
|
Attachment #753452 -
Flags: review?(luke) → review+
Assignee | ||
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e00506a9478f (Try: https://tbpl.mozilla.org/?tree=Try&rev=4bab52e636eb)
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e00506a9478f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•