Closed Bug 87549 Opened 23 years ago Closed 20 years ago

laurentianbank.ca - Web menu doesn't appear

Categories

(Tech Evangelism Graveyard :: French, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: olivierde, Unassigned)

References

()

Details

(Keywords: ecommerce, Whiteboard: [BANK][TOOL][DREAMWEAVER][havefix][havecontact])

At this address there is a series of menu. It looks like the problem is maybe
related to javascript because when you click on these menus there is a
javascript message in the status bar. The problem is that when you click on a
menu you can't see the detail of the menu, so you cannot have access to most of
this site. you should see e.g. under the INFOBLC menu such things as profile,
background a.s.o. This problem exist also with netscape PR 6.1 but it doesn't
exit with netscape 4.77.

Thanks for your product.

Bye
Site uses the Dreamweaver show/hide layers script (v3.0) which uses only
document.layers and document.all DOMs.  Evangelism.
You can see the bad layer code at this URL for the menu frame:
https://www.lbcdirect.laurentianbank.ca/login/Retail/content_en.html
The function MM_findObj() used at this URL comes from MacroMedia:

http://www.macromedia.com/support/dreamweaver/programs/navbar_overview/
navbar_overview04.html


MM_findObj() has been controversial: see bug 51020, bug 43157, for example.
The function in its original form is not W3C-compliant:

function MM_findObj(n,d) { //v3.0
 var p,i,x;  

 if(!d) d=document; 
 if((p=n.indexOf("?"))>0&&parent.frames.length) 
 {
  d=parent.frames[n.substring(p+1)].document; 
  n=n.substring(0,p);
 }

 if(!(x=d[n])&&d.all) 
  x=d.all[n]; 
 for (i=0;!x&&i<d.forms.length;i++) 
  x=d.forms[i][n];
 for(i=0;!x&&d.layers&&i<d.layers.length;i++) 
  x=MM_findObj(n,d.layers[i].document); 
 return x;
}


This version returns a null x in Mozilla, because d.all and d.layers 
are not supported.


Other websites use a version of the function with an extra line: 


function MM_findObj(n,d) { //v3.0
 var p,i,x;  

 if(!d) d=document; 
 if((p=n.indexOf("?"))>0&&parent.frames.length) 
 {
  d=parent.frames[n.substring(p+1)].document; 
  n=n.substring(0,p);
 }

 if(!(x=d[n])&&d.all) 
  x=d.all[n]; 
 for (i=0;!x&&i<d.forms.length;i++) 
  x=d.forms[i][n];
 for(i=0;!x&&d.layers&&i<d.layers.length;i++) 
  x=MM_findObj(n,d.layers[i].document);
 if(!x) x=document.getElementById(n);  <<<<<<<<<<<<<<<<<< FOR W3C, e.g. Mozilla
 return x;
}

 
These functions are hard to read. What makes them work is the continuing test 
for !x beyond the first statement of the function. That is, succeeding 
statements are only applied if x has not already been found...


At any rate, this site needs to update the JavaScript for their
menu functionality. Confirming as an Evangelism bug and reassigning -
Assignee: rogerl → bclary
Status: UNCONFIRMED → NEW
Component: Javascript Engine → Evangelism
Ever confirmed: true
OS: Linux → All
QA Contact: pschwartau → zach
Hardware: PC → All
Summary: Web menu doesn't appear → [LAYER]Web menu doesn't appear
-> Intl
Assignee: bclary → nitot
Blocks: 51020
QA Contact: zach → momoi
Summary: [LAYER]Web menu doesn't appear → laurentianbank.ca- [LAYER]Web menu doesn't appear
Whiteboard: [BANK][TOOL][DREAMWEAVER]
Component: Evangelism → European
Product: Browser → Tech Evangelism
Version: other → unspecified
French Canadian site. Component change.
Component: European → West Europe
QA Contact: momoi → caillon
Putting priority to 3.
Still cannot see the menu on the top bar.
NS 6.2 2001092905094.
Priority: -- → P3
marking havefix, since they just should update the findobj function and we do
have fixed version.
Whiteboard: [BANK][TOOL][DREAMWEAVER] → [BANK][TOOL][DREAMWEAVER][havefix]
contact : https://www.laurentianbank.com/en/08_contact_us/communiquez.htm
Whiteboard: [BANK][TOOL][DREAMWEAVER][havefix] → [BANK][TOOL][DREAMWEAVER][havefix][havecontact]
better contact : mail@laurentianbank.ca .
can anyone contact them with this email ?
Summary: laurentianbank.ca- [LAYER]Web menu doesn't appear → laurentianbank.ca- Web menu doesn't appear
Summary: laurentianbank.ca- Web menu doesn't appear → laurentianbank.ca - Web menu doesn't appear
New Component
Component: Europe: West → French
-> french default owner
Assignee: nitot → french
QA Contact: z-caillon-obsolete2 → french
Just received a positive response from the bank :
"Monsieur Chevrel,
 
En réponse à votre courriel du 8 août 2003, nous tenons à vous informer que
nos services électroniques travaillent actuellement à l'amélioration du
présent site.  Nous avons donc acheminé votre message à ce service à titre
de suggestion.
 
Nous vous remercions d'avoir pris le temps de nous faire part de vos
suggestions,
 
 
Paula Nunziato
Conseillère Internet"
Hello people of the Mozilla community! I'm part of the team that handles the 
Laurentian Bank websites. 

The Laurentian Bank does not officially support the browser(s) that are 
affected by this issue. However, when we find the time, we will do some tests 
with the enumerated solution and will update the menu with the fix. 

Have a nice day.
Thank you François for your help, that's very much appreciated :-)

If you need more info or help for the fix, don't hesitate to ask for help here.
Keywords: ecommerce
I'm working for Laurentian Bank too.

We have a fix to our menu code to be W3C compatible so Mozilla and other browser
will work.

Fix is now in preproduction and will be soon into production.

Thanks for your help.
Hi all, we've updated the Laurentian Bank's menu a while ago. While I wasn't the
one who did the work, I did a quick test with Mozilla FireBird 0.6.1 and
Netscape Communicator 4.8 and it now works fine. 

As a side note, we tried (quite quickly, I must admit! Mea culpa...) updating
the MM_findObj(n,d) function with the solution provided in comment #2; It did
not fix the problem. 

Feel free to dissect the code at https://www.lbcdirect.laurentianbank.ca if
you're curious! The new version also fixes a problem we had: The menu did not
work at all if the user clicked on it before the page was done loading. (Now it
has problems with displaying the images but hey, it's in better shape than it was)

Cheers!

FB
Menus are now fully functionnal and there are no errors in console.
Resolving as FIXED
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Tech Evangelism → Tech Evangelism Graveyard
You need to log in before you can comment on or make changes to this bug.