mach should invoke pymake with an explicit python executable

RESOLVED FIXED in mozilla24

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Trunk
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mach])

(Assignee)

Description

5 years ago
Currently mach invokes pymake as a standard shell command. Since make.py has a #!/usr/bin/env python, the default system python via path search is used. This is not always desirable.

We should launch make.py with the same Python executable that launched mach. Ideally we'd launch with the virtualenv python, but we have no guarantee the virtualenv is populated, so we can't rely on that.
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b05f2692eb73

Reviewed by ted IRL.
Status: NEW → ASSIGNED
Whiteboard: [mach]
Target Milestone: --- → mozilla24
(Assignee)

Comment 2

5 years ago
Fixed bustage when building multiple targets in one go.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7fbc8f75c8c
(Assignee)

Comment 3

5 years ago
And a fix for a path encoding issue. Oh, Windows.

https://hg.mozilla.org/integration/mozilla-inbound/rev/33903d9a63e2
You need to log in before you can comment on or make changes to this bug.