875600 - bootstrap_mac.sh: can't locate 10.6 SDK correctly

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Shao Hang Kao]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130511120803

Steps to reproduce:

run bootstrap_mac.sh


Actual results:

the script can't locate 10.6 SDK


Expected results:

should be able to locate 10.6 SDK

Comment 1

[Shao Hang Kao]

in line 318 it looks wrong:
xcode_dev_path=`xcode-select --print-path`
xcode_path=${xcode_dev_path%/Contents/Developer}

should be:
xcode_path=`xcode-select --print-path`
xcode_dev_path=${xcode_path}/Contents/Developer

Comment 2

[Shao Hang Kao]

https://github.com/mozilla-b2g/B2G/pull/247

Comment 3

[Shao Hang Kao]

Sorry I'm new to this, have no idea how to put the url into attachment? Could someone guide me how to do it? Thanks!

Comment 4

[Shao Hang Kao]

Attachment: Review on github

Comment 5

[Gene Lian (I already quit Mozilla)]

Nice catch! denehs! Btw, please fill in your name field. Btw, Ken is your boss.

Comment 6

[Shao Hang Kao]

Comment on attachment 753581 [details]
Review on github

<html>
  <head>
    <meta http-equiv="Refresh"
    content="2; url=https://github.com/mozilla-b2g/B2G/pull/247" />
  </head>
  <body>
    Redirect to pull request #7808
  </body>
</html>

Comment 7

[Shao Hang Kao]

Attachment: link to pull request

Comment 8

[Shao Hang Kao]

Attachment: link to pull request

Comment 9

[Shao Hang Kao]

Attachment: link to pull request

Comment 10

[Shao Hang Kao]

Attachment: link to pull request

Comment 11

[Shao Hang Kao]

Attachment: link to pull request

Comment 12

[Shao Hang Kao]

sorry for spamming, strange that I can't make the attachment format as text/html...

Comment 13

[Shao Hang Kao]

Attachment: link to pull request

Comment 14

[Eric Shepherd [:sheppy]]

The PR didn't work for me; I commented on the PR about it.

Comment 15

[Michael Wu [:mwu]]

Comment on attachment 753678 [details]
link to pull request

Clearing review since sheppy is reviewing.

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

Eric, are you still looking into this?

Shao, does this still reproduce?

Comment 17

[Shao Hang Kao]

Yes, it still happens on my mac without this patch

Comment 18

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I can duplicate.  they moved the location of the 10.6 sdk

Comment 19

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I think we need to update the download of 10.6 SDK. 

For some people the reason why the patch might not work is because the download of 10.6SDK is broken due to Apple moving it.

https://github.com/denehs/B2G/blob/0f35bf011a26a19d8ad23d5fef38b67a98dc693b/scripts/bootstrap-mac.sh#L234
https://github.com/denehs/B2G/blob/0f35bf011a26a19d8ad23d5fef38b67a98dc693b/scripts/bootstrap-mac.sh#L252
The URL is changed.

Currently our code has :
https://developer.apple.com/downloads/download.action\?path=Developer_Tools/xcode_3.2.6_and_ios_sdk_4.3__final/xcode_3.2.6_and_ios_sdk_4.3.dmg

The new URL is:
http://adcdownload.apple.com/Developer_Tools/xcode_4.3_for_lion_21266/xcode_43_lion.dmg

Could you accommodate your patch to include the change in URL please?  We should probably place it behind a variable and just update the variable whenever Apple changes the location.

Comment 20

[Shao Hang Kao]

well I no longer has the environment to test :( would be great if someone else can take this

Comment 21

[Syd Polk :sydpolk]

I will be in Mountain View this week and have a 10.6 machine in a lab. I will see if I can try this out.

Comment 22

[BMO Automation]

Firefox OS is not being worked on