875610 - Defect - Find in page throws

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P2)

Description

[Rodrigo Silveira [:rsilveira] [:rodms]]

Mostly harmless. I'm seeing this 2 exceptions:
 
Error: this._fastFind.currentWindow is null
Source File: chrome://browser/content/contenthandlers/FindHandler.js
Line: 43

Error: ReferenceError: kBrowserFormZoomLevelMin is not defined
Source File: chrome://browser/content/helperui/FindHelperUI.js
Line: 186

kBrowserFormZoomLevelMin is actually defined in *Form*HelperUI.js but it's not used there. Moving it to FindHelperUI makes find highlighting and page repositioning stop working. Didn't investigate further. We need to make sure the zoom logic is solid at
https://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/helperui/FindHelperUI.js#166

Comment 1

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

this._fastFind.currentWindow was null when opening the findbar for the first time with an empty string.

The zoom code in FindHelperUI doesn't work because we don't have apzc yet, so it ends up messing with the scroll to the found text. I've disabled it by changing the constants so it's easy to re-enable once we get zoom working.

I'll create a bug to track the re-enabling of the find zoom before landing this.

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20c1ebbc31cf

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/20c1ebbc31cf

Comment 4

[Kamil Jozwiak [:kjozwiak]]

Hi Rodrigo,

Is there any way for me to test this? Is there a specific action or website that spawned those error messages? Thanks!

Comment 5

[Rodrigo Silveira [:rsilveira] [:rodms]]

Hi Kamil,

You just need to use find in any page and you'd see those exception on the js console (CTRL + SHIFT + J). If you don't see those exceptions, it's fixed.

Comment 6

[Kamil Jozwiak [:kjozwiak]]

Thanks Rodrigo!

Went through the following "Defect" for iteration #9 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-11-03-02-04-mozilla-central/

- Went through the steps provided in comment 5 and looked for any errors listed in comment 0
- Visited several websites and tapped "Up" & "Down" under the "Find" bar, checked and ensured none of the errors in comment 0 appeared after a few minutes
- Visited several websites and pressed "Enter" under the "Find" bar, checked and ensured none of the errors in comment 0 appeared after a few minutes
- Went through all of the above test cases in "Filled" view without any issues

Comment 7

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #10 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-19-03-02-04-mozilla-central/

- Went through the steps provided in comment 5 and looked for any errors listed in comment 0
- Went through the test cases added in comment 6 without any issues

Comment 8

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130816030205
Built from http://hg.mozilla.org/mozilla-central/rev/1ed5a88cd4d0

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment5 and got expected result.

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Went through the following defect for iteration #20 testing without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-12-22-03-02-04-mozilla-central/

- Went through the steps provided in comment 5 and looked for any errors listed in comment #0
- Used the up/down arrows under the Find App Bar and ensured the errors listed in comment #0 didn't appear
- Used "Enter" under the Find App Bar and ensured that the errors listed in comment #0 didn't appear
- Used "Shift + Enter" under the Find App Bar and ensured that the errors listed in comment #0 didn't appear
- Used the "Search" on the OSK while under the Find App Bar and ensured that the errors listed in comment #0 didn't apppear
- Went through the above test cases in filled view without any issues