875620 - Work around bug 874923 in BindingGen.py

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Something causes pymake to screw up, as far as I can tell, and not pull in the right .pp files when doing bindinggen.  The symptom is that .changed-dependency-list contains only ParserResults.pkl but not any *Binding files, even though WebIDL files changed.

Bug 874923 tracks this, but I'm going to put a workaround in BindingGen.py in the meantime so we can stop busting the tree.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Work around bug 874923 by just trying to regenerate all the binding .h and .cpp files if we detect that our dependencies got screwed up.

Still needs testing

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 753604 [details] [diff] [review]
Work around bug 874923 by just trying to regenerate all the binding .h and .cpp files if we detect that our dependencies got screwed up.

Seems to work.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Better Patch

This fixes my problems.  I'm not sure whether it's papering over a pymake bug or not ...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 754360 [details] [diff] [review]
Better Patch

Per IRC discussion, this presumably regenerates the .cpp during libs, which is ok to work around .cpp files not getting updated, but will fail to deal with the case of a .h not getting updated...

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 753604 [details] [diff] [review]
Work around bug 874923 by just trying to regenerate all the binding .h and .cpp files if we detect that our dependencies got screwed up.

Kyle said r=him on IRC, but will let him stamp this.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca3cba56b35e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca3cba56b35e