Closed Bug 875620 Opened 8 years ago Closed 8 years ago

Work around bug 874923 in BindingGen.py

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files)

Something causes pymake to screw up, as far as I can tell, and not pull in the right .pp files when doing bindinggen.  The symptom is that .changed-dependency-list contains only ParserResults.pkl but not any *Binding files, even though WebIDL files changed.

Bug 874923 tracks this, but I'm going to put a workaround in BindingGen.py in the meantime so we can stop busting the tree.
Comment on attachment 753604 [details] [diff] [review]
Work around bug 874923 by just trying to regenerate all the binding .h and .cpp files if we detect that our dependencies got screwed up.

Seems to work.
Attachment #753604 - Flags: review?(khuey)
Attached patch Better PatchSplinter Review
This fixes my problems.  I'm not sure whether it's papering over a pymake bug or not ...
Attachment #754360 - Flags: review?(bzbarsky)
Comment on attachment 754360 [details] [diff] [review]
Better Patch

Per IRC discussion, this presumably regenerates the .cpp during libs, which is ok to work around .cpp files not getting updated, but will fail to deal with the case of a .h not getting updated...
Attachment #754360 - Flags: review?(bzbarsky) → review-
Comment on attachment 753604 [details] [diff] [review]
Work around bug 874923 by just trying to regenerate all the binding .h and .cpp files if we detect that our dependencies got screwed up.

Kyle said r=him on IRC, but will let him stamp this.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca3cba56b35e
Attachment #753604 - Flags: review- → review?
Attachment #753604 - Flags: review? → review?(khuey)
https://hg.mozilla.org/mozilla-central/rev/ca3cba56b35e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [need review]
Target Milestone: --- → mozilla24
Blocks: 874923
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.