Replace the callers of GetDefaultDownloadsDirectory with Downloads.getSystemDownloadsDirectory

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
6 years ago
5 years ago

People

(Reporter: raymondlee, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
Few places are using GetDefaultDownloadsDirectory. 
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp

Should replace them with async Downloads.getSystemDownloadsDirectory if possible.

Updated

5 years ago
Blocks: 851471

Updated

5 years ago
No longer blocks: 825588

Comment 1

5 years ago
Isn't this the same as 875648?
(Reporter)

Comment 2

5 years ago
(In reply to Neil Deakin from comment #1)
> Isn't this the same as 875648?

I think this bug is about updating the GetDefaultDownloadsDirectory inside nsDownloadManager.cpp. 
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp#1469

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp#1501

Whereas, bug 875648 is about js script which uses defaultDownloadsDirectory via the nsIDownloadManager interface.

Comment 3

5 years ago
Both of those callers are within GetUserDownloadsDirectory which is also looking to be replaced, so I don't think there is anything to fix here.
(Reporter)

Comment 4

5 years ago
(In reply to Neil Deakin from comment #3)
> Both of those callers are within GetUserDownloadsDirectory which is also
> looking to be replaced, so I don't think there is anything to fix here.

Yes.  Lets mark this as WONTFIX.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.