875654 - Replace the callers of GetDefaultDownloadsDirectory with Downloads.getSystemDownloadsDirectory

Status: RESOLVED WONTFIX

(Toolkit :: Downloads API, defect)

Description

[Raymond Lee [:raymondlee]]

Few places are using GetDefaultDownloadsDirectory. 
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp

Should replace them with async Downloads.getSystemDownloadsDirectory if possible.

Comment 1

[Neil Deakin]

Isn't this the same as 875648?

Comment 2

[Raymond Lee [:raymondlee]]

(In reply to Neil Deakin from comment #1)
> Isn't this the same as 875648?

I think this bug is about updating the GetDefaultDownloadsDirectory inside nsDownloadManager.cpp. 
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp#1469

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp#1501

Whereas, bug 875648 is about js script which uses defaultDownloadsDirectory via the nsIDownloadManager interface.

Comment 3

[Neil Deakin]

Both of those callers are within GetUserDownloadsDirectory which is also looking to be replaced, so I don't think there is anything to fix here.

Comment 4

[Raymond Lee [:raymondlee]]

(In reply to Neil Deakin from comment #3)
> Both of those callers are within GetUserDownloadsDirectory which is also
> looking to be replaced, so I don't think there is anything to fix here.

Yes.  Lets mark this as WONTFIX.