Closed Bug 875654 Opened 9 years ago Closed 9 years ago

Replace the callers of GetDefaultDownloadsDirectory with Downloads.getSystemDownloadsDirectory

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: raymondlee, Unassigned)

References

Details

Few places are using GetDefaultDownloadsDirectory. 
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp

Should replace them with async Downloads.getSystemDownloadsDirectory if possible.
Blocks: 851471
No longer blocks: jsdownloads
Isn't this the same as 875648?
(In reply to Neil Deakin from comment #1)
> Isn't this the same as 875648?

I think this bug is about updating the GetDefaultDownloadsDirectory inside nsDownloadManager.cpp. 
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp#1469

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp#1501

Whereas, bug 875648 is about js script which uses defaultDownloadsDirectory via the nsIDownloadManager interface.
Both of those callers are within GetUserDownloadsDirectory which is also looking to be replaced, so I don't think there is anything to fix here.
(In reply to Neil Deakin from comment #3)
> Both of those callers are within GetUserDownloadsDirectory which is also
> looking to be replaced, so I don't think there is anything to fix here.

Yes.  Lets mark this as WONTFIX.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.