Remove the "driver.js" module from mozmill code

RESOLVED FIXED

Status

Testing Graveyard
Mozmill
RESOLVED FIXED
4 years ago
9 months ago

People

(Reporter: Daniela Petrovici, Assigned: gaurav0x, Mentored)

Tracking

Details

(Whiteboard: [lang=js][good first bug][mozmill-2.1])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Driver.js library should be removed from mozmill 2.0. 

It was used by the refactoring of the mozmill tests. Also it is not necessary with the move to marionette.
Whiteboard: [mentor=whimboo][lang=js][good first bug]
The file to be removed can be found here:
https://github.com/mozilla/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/driver.js

Comment 2

4 years ago
Hi, I'm new in the community, already 3 days I'm trying to start contributing.
I really need a mentor.
Can I start with this?
Hi toman! Welcome to our community! It's great to have you here, and I hope you will enjoy working on this bug. To get started with Mozmill you might want to have a look in our Wiki:
https://wiki.mozilla.org/Auto-tools/Projects/Mozmill/RepoSetup

If you need further information you can join our #automation channel on IRC.
I will assign the bug to you now, so that no-one else would start on it. Please let me known if you have further questions.
Assignee: nobody → toman22
Status: NEW → ASSIGNED

Comment 5

3 years ago
Hello toman, hello whimboo.

Toman, are you still working on the bug ?
Whimboo, I would like to work on this if Toman isnt contributing.
Flags: needinfo?(toman22)
Mentor: hskupin@gmail.com
Whiteboard: [mentor=whimboo][lang=js][good first bug] → [lang=js][good first bug]
Amod, are you still interested in working on this?
Assignee: toman22 → nobody
Flags: needinfo?(toman22) → needinfo?(amod.narvekar)

Comment 7

3 years ago
Yes. I request you for 1 week's time. I would return to bugzilla soon. Thanks !
Flags: needinfo?(amod.narvekar)
(Assignee)

Comment 8

3 years ago
I want to work on it.. i'm newbie...do i just need to delete that file?
(Assignee)

Comment 9

3 years ago
I want to work on it.. i'm newbie...do i just need to delete that file?
(Assignee)

Comment 10

3 years ago
Created attachment 8496992 [details] [diff] [review]
I-removed-the-driver.js-module-from-mozmill.patch

I tried to fix the bug.here's my patch..check it out..
Attachment #8496992 - Flags: review?(hskupin)
(Assignee)

Comment 11

3 years ago
and do assign the bug to me

Comment 12

3 years ago
Hi is this bug being worked on? If not I would like to work on it please.

Thanks

Jesal
Hi Gaurav. Sorry for the delay here! Thank you for taking a stab on working on it. I will do a review in a bit.
Assignee: nobody → gaurav_rai
Comment on attachment 8496992 [details] [diff] [review]
I-removed-the-driver.js-module-from-mozmill.patch

Review of attachment 8496992 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.
Attachment #8496992 - Flags: review?(hskupin) → review+
I have updated the commit message so it conforms our guidelines and got the patch pushed to the master branch so it will be part of Mozmill 2.1:

https://github.com/mozilla/mozmill/commit/b6f577d63dbb7ae89ecde665457c08729db611be

Gaurav, if you want to help with some other challenging task please let me know. Jesal, the same applies to you. First place to look at should be http://www.joshmatthews.net/bugsahoy/?automation=1&unowned=1&simple=1. Thanks
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [lang=js][good first bug] → [lang=js][good first bug][mozmill-2.1]
(Assignee)

Comment 16

3 years ago
Thanks Henrik and I would really like to work on some challenging bug. Do tell me if you have any on your mind (C++,Js,Html,Css)
Gaurav, something where we would need help with is bug 879946. Those lookups are busting our test results each time elements are changed. If you think that you can help us, I would appreciate your assistance!
(In reply to Henrik Skupin (:whimboo) from comment #17)
> Gaurav, something where we would need help with is bug 879946. Those lookups

Gaurav, would that be a good candidate for you?
Flags: needinfo?(gaurav_rai)
(Assignee)

Comment 19

3 years ago
I want to work on that bug but can you help me understand that bug?
Flags: needinfo?(gaurav_rai)
Sure. Lets move the conversation to the other bug then.
This patch actually missed to remove the require line from inside the frame.js module. So Mozmill was broken on the master branch. I pushed a bustage fix to be able to continue with development.

https://github.com/mozilla/mozmill/commit/e04eec8628ad3f64a3ef9ef557ad15c0e60ea3cb
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.