875824 - Nightly crash on startup Galaxy S4 ( SIV ) GT-I9505

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mike Hommey [:glandium]]

As per bug 874708 comment 11:

"I think a reasonable way forward here is to setup a blacklist of devices where we disable on-demand decompression at runtime."

I'm keeping bug 874708 open for a real fix, this is a bug for temporary mitigation (and framework if we need to deal with similar crashes on other devices).

Comment 1

[Mike Hommey [:glandium]]

Attachment: Allow to disable on-demand decompression at runtime

Comment 2

[Mike Hommey [:glandium]]

Attachment: Disable on-demand decompression of the linker on devices where it is known to cause crashes

This should work, but I'd like AaronMT or kbrosnan to validate
(build at http://people.mozilla.org/~mhommey/fennec-24.0a1.en-US.android-arm.apk )

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 753929 [details] [diff] [review]
Disable on-demand decompression of the linker on devices where it is known to cause crashes

Review of attachment 753929 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: mobile/android/base/mozglue/GeckoLoader.java.in
@@ +207,5 @@
>  
> +        // Disable on-demand decompression of the linker on devices where it
> +        // is known to cause crashes.
> +        if (android.os.Build.MANUFACTURER == "samsung" &&
> +            android.os.Build.MODEL == "GT-I9505") {

You should .equals() instead of == for strings. In general also the idiom "constant".equals(variable) is better than variable.equals("constant") because the former doesn't NPE if variable is null. I don't think the Build constants will be null though so it doesn't matter here.

Comment 4

[Aaron Train [:aaronmt]]

(In reply to Mike Hommey [:glandium] from comment #2)
> This should work, but I'd like AaronMT or kbrosnan to validate
> (build at
> http://people.mozilla.org/~mhommey/fennec-24.0a1.en-US.android-arm.apk )

Build works for me.

>+        // Disable on-demand decompression of the linker on devices where it
>+        // is known to cause crashes.
>+        if (android.os.Build.MANUFACTURER == "samsung" &&
>+            android.os.Build.MODEL == "GT-I9505") {
>+            putenv("MOZ_LINKER_ONDEMAND=0");
>+        }

Matches look good to me:

$ getprop | grep product
[ril.product_code]: [GT-I9505ZKABTU]
[ro.product.brand]: [samsung]
[ro.product.manufacturer]: [samsung]
[ro.product.model]: [GT-I9505]

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 753916 [details] [diff] [review]
Allow to disable on-demand decompression at runtime

Julian, can you take a look at this while Nathan is on PTO?

Comment 6

[Julian Seward [:jseward]]

Comment on attachment 753916 [details] [diff] [review]
Allow to disable on-demand decompression at runtime

Review of attachment 753916 [details] [diff] [review]:
-----------------------------------------------------------------

Looks plausible to me.

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d47ebe4dfea6
https://hg.mozilla.org/integration/mozilla-inbound/rev/4655d7317a03

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d47ebe4dfea6
https://hg.mozilla.org/mozilla-central/rev/4655d7317a03

Comment 9

[Aaron Train [:aaronmt]]

Latest mozilla-central builds today startup on my device