875849 - Update marketplace packaged app to include fix in bug 875734

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Comment 1

[Wil Clouser [:clouserw]]

https://github.com/mozilla-b2g/gaia/pull/9995

Comment 2

[Jason Smith [:jsmith]]

Attachment: Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/9995

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 753987 [details]
Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/9995

In the manifest there is:
"messages": [
        {"mobilenetwork": "/index.html"}
    ],

We have no such system message. Please remove that.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

That one was already there in the previous PR pulled in, but will remove.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Check now, please

Comment 6

[Christopher Van Wiemeersch [:cvan]]

BTW, Fabrice, if you pull in that change the signed package will no longer be valid. Does the .zip that gets shipped with Gaia need to be a signed package? If so, let's go with the previous version. Resigning this package will require another push to production.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #6)
> BTW, Fabrice, if you pull in that change the signed package will no longer
> be valid. Does the .zip that gets shipped with Gaia need to be a signed
> package? If so, let's go with the previous version. Resigning this package
> will require another push to production.

Err....let's make that a signed package. Not sure if it's a good idea if we didn't do that.

Comment 8

[Jason Smith [:jsmith]]

Clearing review to wait to address comment 7.

Comment 9

[[:fabrice] Fabrice Desré]

No need to sign the preloaded apps. If the etag is ok that's good enough.

Comment 10

[Jason Smith [:jsmith]]

Comment on attachment 753987 [details]
Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/9995

Okay, in that case - flipping review back on to land.

Comment 11

[[:fabrice] Fabrice Desré]

Comment on attachment 753987 [details]
Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/9995

r=me if you remove the _MACOSX folder from the package. I'm also sad that there is no localization in the app manifest.

Comment 12

[Christopher Van Wiemeersch [:cvan]]

r? https://github.com/mozilla-b2g/gaia/pull/9995

Comment 13

[Ryan VanderMeulen [:RyanVM]]

John, can you assist please?

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

master: 1324eea
v1-train: e9836ba
v1.0.1: f40d592

Comment 15

[Sarah Parsons]

This issue reproduces on the Inari 1.0.1 Build ID: 20130624070215 per repro steps in bug 875734 

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0
Gaia: 93241eb6c5d6c110710fad8da3ccd4423312b0c9
Platform Version: 18.0

This also reproduced on Unagi 1.1 Build ID: 20130624070224

Environmental Variables
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/62049a1c5d36
Gaia: 885b874029d8143035765ae903c147a9415fcc52
Platform Version: 18.1

Blue web page saying that the device is in Offline Mode is shown indicating that "in offline mode can't browse the Web".

Comment 16

[Julien Wajsberg [:julienw]]

john, I don't see your commits on v1-train nor v1.0.1.

Doing the uplift :)

v1-train: 07105039ff85c07a7e949b8c670a50383fa98d56
v1.0.1: b938b103660918f1fc0fccc04b77904dc47395ec

I'm afraid it's too late for 1.0.1 though :/

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 07105039ff85c07a7e949b8c670a50383fa98d56