Closed Bug 875917 Opened 8 years ago Closed 8 years ago

Use xor instead of movl to zero a register in a few places

Categories

(Core :: JavaScript Engine, enhancement)

x86_64
All
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: sunfish, Unassigned)

Details

Attachments

(2 files)

CodeGenerator-x86-shared.cpp and CodeGenerator-x86.cpp both currently use mov to zero a register in a context where the condition codes aren't live.
Attached patch a proposed fixSplinter Review
Attachment #753934 - Flags: review?(luke)
Comment on attachment 753934 [details] [diff] [review]
a proposed fix

Thanks!
Attachment #753934 - Flags: review?(luke) → review+
just as a stupid follow-up nit, note that if the else branch has brackets, then our style requires all branches to have brackets.
https://hg.mozilla.org/mozilla-central/rev/44385c2f40be
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Attachment #760507 - Flags: review?(sstangl)
Attachment #760507 - Flags: review?(sstangl) → review+
You need to log in before you can comment on or make changes to this bug.