Use xor instead of movl to zero a register in a few places

RESOLVED FIXED in mozilla24

Status

()

--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sunfish, Unassigned)

Tracking

Trunk
mozilla24
x86_64
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
CodeGenerator-x86-shared.cpp and CodeGenerator-x86.cpp both currently use mov to zero a register in a context where the condition codes aren't live.
(Reporter)

Comment 1

6 years ago
Created attachment 753934 [details] [diff] [review]
a proposed fix
Attachment #753934 - Flags: review?(luke)

Comment 2

6 years ago
Comment on attachment 753934 [details] [diff] [review]
a proposed fix

Thanks!
Attachment #753934 - Flags: review?(luke) → review+
just as a stupid follow-up nit, note that if the else branch has brackets, then our style requires all branches to have brackets.

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/44385c2f40be
Status: UNCONFIRMED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
(Reporter)

Comment 6

6 years ago
Created attachment 760507 [details] [diff] [review]
fix missing braces
Attachment #760507 - Flags: review?(sstangl)

Updated

6 years ago
Attachment #760507 - Flags: review?(sstangl) → review+
You need to log in before you can comment on or make changes to this bug.