Closed Bug 875949 Opened 8 years ago Closed 8 years ago

"leaked" provider test cleanup

Categories

(Firefox Graveyard :: SocialAPI, defect)

21 Branch
x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch test fixes (obsolete) — Splinter Review
while investigating intermittent failures in bug 847124 and bug 846600 I noticed a provider pref hanging around throughout the social tests.  This patch:

- fixes leak of pref into later tests
- ensures added providers are fully removed prior to finishing test file
- adds new check at end of each test file to check that providers have been properly cleared out
Attachment #753962 - Flags: review?(felipc)
I found one other test leaving a provider enabled.  This adds to the previous patch a check between tests that we don't forget or fail to remove a provider we added for an individual test.
Assignee: nobody → mixedpuppy
Attachment #753962 - Attachment is obsolete: true
Attachment #753962 - Flags: review?(felipc)
Attachment #753999 - Flags: review?(felipc)
Summary: activation test cleanup → "leaked" provider test cleanup
Comment on attachment 753999 [details] [diff] [review]
test provider leakage between tests

Review of attachment 753999 [details] [diff] [review]:
-----------------------------------------------------------------

Good clean-up! It's a bit confusing for someone writing a new test to have this callback set-up of either calling one or the other.. Are tests expected to call finish manually if they define a callback?

Not sure about the naming and spelling of finallFinishChecks.. Maybe defaultFinishChecks? It also helps clarify it can be overriden.
Attachment #753999 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/4e3c25f31bdc
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.