Add default settings for some new device storage settings

RESOLVED FIXED in 1.1 QE2 (6jun)

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dhylands, Assigned: dhylands)

Tracking

unspecified
1.1 QE2 (6jun)
ARM
Gonk (Firefox OS)
Dependency tree / graph
Bug Flags:
in-moztrap -

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
As suggested in the review of bug 875637, this bug adds the default values for:

device.storage.writable.name to be 'sdcard'

and for ums.volume.sdcard.enabled to be true.

This should be leo+
(Assignee)

Comment 1

5 years ago
Created attachment 754061 [details] [diff] [review]
Added defaults for the new settings in device storage and the automounter.
(Assignee)

Comment 2

5 years ago
Comment on attachment 754061 [details] [diff] [review]
Added defaults for the new settings in device storage and the automounter.

These options were introduced in bug 856782 (settings app) and used by the patches in bug 858416 (device storage) and bug 852768 (automounter)
Attachment #754061 - Flags: review?(anygregor)
(Assignee)

Updated

5 years ago
Blocks: 858416, 852768
Comment on attachment 754061 [details] [diff] [review]
Added defaults for the new settings in device storage and the automounter.

Review of attachment 754061 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #754061 - Flags: review?(anygregor) → review+
(Assignee)

Comment 4

5 years ago
https://github.com/mozilla-b2g/gaia/commit/1dd7b39de59258cce237d5ae732ecac1c3868cc5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
status-b2g18: --- → affected
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → affected
status-firefox22: --- → affected
I think this is also needed for v1train
status-b2g18-v1.0.1: affected → wontfix
status-firefox22: affected → ---

Updated

5 years ago
blocking-b2g: leo? → leo+
Keywords: checkin-needed
Target Milestone: --- → 1.1 QE2 (6jun)
(In reply to Dave Hylands [:dhylands] from comment #4)
> https://github.com/mozilla-b2g/gaia/commit/
> 1dd7b39de59258cce237d5ae732ecac1c3868cc5

John, can you assist with the uplift please?
Flags: needinfo?(jhford)
v1-train: 5d79485
status-b2g18: affected → fixed
Flags: needinfo?(jhford)
Keywords: checkin-needed

Comment 8

5 years ago
in-moztrap-, as i dont think there is UI for this to test against.
Flags: in-moztrap-
(Assignee)

Comment 9

5 years ago
There is currently no UI for this feature. It was added for the new apps which want to present places to save data to the user.

The ds-test app can expose this (I've made some changes to ds-test, but haven't checked it in yet).
You need to log in before you can comment on or make changes to this bug.