Closed
Bug 876157
Opened 12 years ago
Closed 12 years ago
Avoid expensive nsSVGGradientFrame::GetGradientTransform calls when gradients paint only a single color
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
2.35 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
In bug 780762 I'm seeing nsSVGGradientFrame::GetGradientTransform being hit for 6% of the samples, which is stupid given that all the gradients in that bug's testcase only paint a single color. The reason the call is so expensive is because it needs to call GetBBox since the gradients use the (default) value of "objectBoundingBox" for the "gradientUnits" attribute.
We should avoid expensive nsSVGGradientFrame::GetGradientTransform calls when gradients paint only a single color.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #754146 -
Flags: review?(roc)
Attachment #754146 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•